Changeset 145735 in webkit

Timestamp:

Mar 13, 2013, 12:14:31 PM (12 years ago)

Author:

Nate Chapin

Message:

.: Expose symbols for internals
​https://bugs.webkit.org/show_bug.cgi?id=112194

Reviewed by Alexey Proskuryakov.

• Source/autotools/symbols.filter:

Source/WebCore: REGRESSION(r137607): Redirecting a post to a get then reloading triggers resubmit warning
​https://bugs.webkit.org/show_bug.cgi?id=112194

Reviewed by Alexey Proskuryakov.

Test: http/tests/navigation/post-redirect-get-reload.php

• loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::willSendRequest): Matching urls aren't a reliable way of checking whether

we are in a redirect. Check redirectResponse.isNull() instead.

• testing/Internals.cpp:

(WebCore::Internals::forceReload): Expose a means of forcing a reload like one a user generates for testing.

Note that testRunner.queueReload() does this, but is not supported after the initial load completes,
which makes it unsuitable for this case.

• testing/Internals.h:
• testing/Internals.idl:

Source/WebKit/win: Expose symbols for internals
​https://bugs.webkit.org/show_bug.cgi?id=112194

Reviewed by Alexey Proskuryakov.

• WebKit.vcproj/WebKitExports.def.in:

LayoutTests: Test for ​https://bugs.webkit.org/show_bug.cgi?id=112194.

Reviewed by Alexey Proskuryakov.

• http/tests/navigation/post-redirect-get-reload-expected.txt: Added.
• http/tests/navigation/post-redirect-get-reload.php: Added.

Location:

trunk

Files:

• ChangeLog (modified) (1 diff)
• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/http/tests/navigation/post-redirect-get-reload-expected.txt (added)
• LayoutTests/http/tests/navigation/post-redirect-get-reload.php (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/loader/SubresourceLoader.cpp (modified) (1 diff)
• Source/WebCore/testing/Internals.cpp (modified) (2 diffs)
• Source/WebCore/testing/Internals.h (modified) (1 diff)
• Source/WebCore/testing/Internals.idl (modified) (1 diff)
• Source/WebKit/win/ChangeLog (modified) (1 diff)
• Source/WebKit/win/WebKit.vcproj/WebKitExports.def.in (modified) (1 diff)
• Source/autotools/symbols.filter (modified) (1 diff)

trunk/ChangeLog

@@ +1 @@
+2013-03-13  Nate Chapin  <japhet@chromium.org>
+
+        Expose symbols for internals
+        https://bugs.webkit.org/show_bug.cgi?id=112194
+
+        Reviewed by Alexey Proskuryakov.
+
+        * Source/autotools/symbols.filter:
+
 2013-03-12  Zan Dobersek  <zdobersek@igalia.com>
 

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-03-13  Nate Chapin  <japhet@chromium.org>
+
+        Test for https://bugs.webkit.org/show_bug.cgi?id=112194.
+
+        Reviewed by Alexey Proskuryakov.
+
+        * http/tests/navigation/post-redirect-get-reload-expected.txt: Added.
+        * http/tests/navigation/post-redirect-get-reload.php: Added.
+
 2013-03-13  Andrei Bucur  <abucur@adobe.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-03-13  Nate Chapin  <japhet@chromium.org>
+
+        REGRESSION(r137607): Redirecting a post to a get then reloading triggers resubmit warning
+        https://bugs.webkit.org/show_bug.cgi?id=112194
+
+        Reviewed by Alexey Proskuryakov.
+
+        Test: http/tests/navigation/post-redirect-get-reload.php
+
+        * loader/SubresourceLoader.cpp:
+        (WebCore::SubresourceLoader::willSendRequest): Matching urls aren't a reliable way of checking whether
+            we are in a redirect. Check redirectResponse.isNull() instead.
+        * testing/Internals.cpp:
+        (WebCore::Internals::forceReload): Expose a means of forcing a reload like one a user generates for testing.
+            Note that testRunner.queueReload() does this, but is not supported after the initial load completes,
+            which makes it unsuitable for this case.
+        * testing/Internals.h:
+        * testing/Internals.idl:
+
 2013-03-13  Nate Chapin  <japhet@chromium.org>
 

trunk/Source/WebCore/loader/SubresourceLoader.cpp

@@ -133 +133 @@
 
     ASSERT(!newRequest.isNull());
-    if (!previousURL.isNull() && previousURL != newRequest.url()) {
+    if (!redirectResponse.isNull()) {
         if (!m_documentLoader->cachedResourceLoader()->canRequest(m_resource->type(), newRequest.url())) {
             cancel();

trunk/Source/WebCore/testing/Internals.cpp

@@ -48 +48 @@
 #include "FormController.h"
 #include "Frame.h"
+#include "FrameLoader.h"
 #include "FrameView.h"
 #include "HTMLContentElement.h"
@@ -2041 +2042 @@
 }
 
+void Internals::forceReload(bool endToEnd)
+{
+    frame()->loader()->reload(endToEnd);
+}
+
 #if ENABLE(ENCRYPTED_MEDIA_V2)
 void Internals::initializeMockCDM()

trunk/Source/WebCore/testing/Internals.h

@@ -289 +289 @@
     String markerTextForListItem(Element*, ExceptionCode&);
 
+    void forceReload(bool endToEnd);
+
 #if ENABLE(ENCRYPTED_MEDIA_V2)
     void initializeMockCDM();

trunk/Source/WebCore/testing/Internals.idl

@@ -258 +258 @@
     void setUsesOverlayScrollbars(in boolean enabled);
 
+    void forceReload(in boolean endToEnd);
+
     [Conditional=ENCRYPTED_MEDIA_V2] void initializeMockCDM();
 

trunk/Source/WebKit/win/ChangeLog

@@ +1 @@
+2013-03-13  Nate Chapin  <japhet@chromium.org>
+
+        Expose symbols for internals
+        https://bugs.webkit.org/show_bug.cgi?id=112194
+
+        Reviewed by Alexey Proskuryakov.
+
+        * WebKit.vcproj/WebKitExports.def.in:
+
 2013-03-13  Pavel Feldman  <pfeldman@chromium.org>
 

trunk/Source/WebKit/win/WebKit.vcproj/WebKitExports.def.in

@@ -247 +247 @@
         ?placeholderShouldBeVisible@HTMLTextFormControlElement@WebCore@@QBE_NXZ
         ?rangeFromLocationAndLength@TextIterator@WebCore@@SA?AV?$PassRefPtr@VRange@WebCore@@@WTF@@PAVContainerNode@2@HH_N@Z
+        ?reload@FrameLoader@WebCore@@QAEX_N@Z
         ?remove@String@WTF@@QAEXIH@Z
         ?removedLastRef@Node@WebCore@@AAEXXZ

trunk/Source/autotools/symbols.filter

@@ -260 +260 @@
 _ZNK7WebCore5Frame25trackedRepaintRectsAsTextEv;
 _ZN7WebCore4toJSEPN3JSC9ExecStateEPNS_17JSDOMGlobalObjectEPN3WTF11ArrayBufferE;
+_ZN7WebCore11FrameLoader6reloadEb;
 _ZN7WebCore13toArrayBufferEN3JSC7JSValueE;
 _ZN7WebCore21SerializedScriptValue11deserializeEPN3JSC9ExecStateEPNS1_14JSGlobalObjectEPN3WTF6VectorINS6_6RefPtrINS_11MessagePortEEELj1EEENS_22SerializationErrorModeE;