Changeset 146125 in webkit

Timestamp:

Mar 18, 2013, 2:30:00 PM (13 years ago)

Author:

zandobersek@gmail.com

Message:

[webkitpy] '/usr/bin/interdiff' output while running test-webkitpy
​https://bugs.webkit.org/show_bug.cgi?id=112622

Reviewed by Dirk Pranke.

• Scripts/webkitpy/tool/steps/haslanded_unittest.py:

(HasLandedTest): Pipe the stdout and stderr output of the subprocess call to subprocess.PIPE, eliminating unnecessary output.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/tool/steps/haslanded_unittest.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
+
+        [webkitpy] '/usr/bin/interdiff' output while running test-webkitpy
+        https://bugs.webkit.org/show_bug.cgi?id=112622
+
+        Reviewed by Dirk Pranke.
+
+        * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
+        (HasLandedTest): Pipe the stdout and stderr output of the subprocess call to subprocess.PIPE, eliminating unnecessary output.
+
 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
 

trunk/Tools/Scripts/webkitpy/tool/steps/haslanded_unittest.py

@@ -36 +36 @@
     maxDiff = None
 
-    @unittest.skipUnless(subprocess.call('which interdiff', shell=True) == 0, "requires interdiff")
+    @unittest.skipUnless(subprocess.call('which interdiff', shell=True, stdout=subprocess.PIPE, stderr=subprocess.PIPE) == 0, "requires interdiff")
     def test_run(self):
         # These patches require trailing whitespace to remain valid patches.