Changeset 146224 in webkit


Ignore:
Timestamp:
Mar 19, 2013, 11:20:35 AM (12 years ago)
Author:
tdanderson@chromium.org
Message:

Hover effects from a GestureTapDown are dismissed by a GestureTap on the hover element
​https://bugs.webkit.org/show_bug.cgi?id=103283

Reviewed by Antonio Gomes.

Source/WebCore:

On a GestureTap event over an element that was made visible as a hover effect, the
GestureTap should be applied to that element and the hover effects should not be dismissed.
A GestureTap or a mouse move to a location outside of the element should still dismiss the
hover effects.

Tests: fast/events/touch/gesture/gesture-tap-hover-clear.html

fast/events/touch/gesture/gesture-tap-on-hover-element.html

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleGestureEvent):

LayoutTests:

Two layout tests added. See descriptions inline.

  • fast/events/touch/gesture/gesture-tap-hover-clear-expected.txt: Added.
  • fast/events/touch/gesture/gesture-tap-hover-clear.html: Added.

Tests that a GestureTap or a mouse move outside of the hovered element
clears its hover effects.

  • fast/events/touch/gesture/gesture-tap-on-hover-element-expected.txt: Added.
  • fast/events/touch/gesture/gesture-tap-on-hover-element.html: Added.

Tests that a GestureTap on an element which has been made visible as
a hover effect is dispatched to the element and does not dismiss the
hover effect.

  • platform/chromium/fast/events/touch/gesture/gesture-tap-hover-clear-expected.txt: Added.
  • platform/chromium/fast/events/touch/gesture/gesture-tap-on-hover-element-expected.txt: Added.
Location:
trunk
Files:
6 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r146221 r146224  
     12013-03-19  Terry Anderson  <tdanderson@chromium.org>
     2
     3        Hover effects from a GestureTapDown are dismissed by a GestureTap on the hover element
     4        https://bugs.webkit.org/show_bug.cgi?id=103283
     5
     6        Reviewed by Antonio Gomes.
     7
     8        Two layout tests added. See descriptions inline.
     9
     10        * fast/events/touch/gesture/gesture-tap-hover-clear-expected.txt: Added.
     11        * fast/events/touch/gesture/gesture-tap-hover-clear.html: Added.
     12              Tests that a GestureTap or a mouse move outside of the hovered element
     13              clears its hover effects.
     14        * fast/events/touch/gesture/gesture-tap-on-hover-element-expected.txt: Added.
     15        * fast/events/touch/gesture/gesture-tap-on-hover-element.html: Added.
     16              Tests that a GestureTap on an element which has been made visible as
     17              a hover effect is dispatched to the element and does not dismiss the
     18              hover effect.
     19        * platform/chromium/fast/events/touch/gesture/gesture-tap-hover-clear-expected.txt: Added.
     20        * platform/chromium/fast/events/touch/gesture/gesture-tap-on-hover-element-expected.txt: Added.
     21
    1222013-03-19  Simon Fraser  <simon.fraser@apple.com>
    223

  • trunk/Source/WebCore/ChangeLog

    r146220 r146224  
     12013-03-19  Terry Anderson  <tdanderson@chromium.org>
     2
     3        Hover effects from a GestureTapDown are dismissed by a GestureTap on the hover element
     4        https://bugs.webkit.org/show_bug.cgi?id=103283
     5
     6        Reviewed by Antonio Gomes.
     7
     8        On a GestureTap event over an element that was made visible as a hover effect, the
     9        GestureTap should be applied to that element and the hover effects should not be dismissed.
     10        A GestureTap or a mouse move to a location outside of the element should still dismiss the
     11        hover effects.
     12
     13        Tests: fast/events/touch/gesture/gesture-tap-hover-clear.html
     14               fast/events/touch/gesture/gesture-tap-on-hover-element.html
     15
     16        * page/EventHandler.cpp:
     17        (WebCore::EventHandler::handleGestureEvent):
     18
    1192013-03-19  Alexei Filippov  <alph@chromium.org>
    220

  • trunk/Source/WebCore/page/EventHandler.cpp

    r145913 r146224  
    24762476#endif
    24772477        hitType |= HitTestRequest::Active;
    2478     } else if (gestureEvent.type() == PlatformEvent::GestureTap || gestureEvent.type() == PlatformEvent::GestureTapDownCancel)
     2478    } else if (gestureEvent.type() == PlatformEvent::GestureTapDownCancel)
    24792479        hitType |= HitTestRequest::Release;
     2480    else if (gestureEvent.type() == PlatformEvent::GestureTap) {
     2481        // The mouseup event synthesized for this gesture will clear the active state of the
     2482        // targeted node, so performing a ReadOnly hit test here is fine.
     2483        hitType |= HitTestRequest::ReadOnly;
     2484    }
    24802485    else
    24812486        hitType |= HitTestRequest::Active | HitTestRequest::ReadOnly;
Note: See TracChangeset for help on using the changeset viewer.