Changeset 146295 in webkit

Timestamp:

Mar 19, 2013, 7:38:54 PM (12 years ago)

Author:

commit-queue@webkit.org

Message:

Cache a pointer to V8DOMActivityLogger in PerContextData.
​https://bugs.webkit.org/show_bug.cgi?id=112719

Patch by Ankur Taly <​ataly@google.com> on 2013-03-19
Reviewed by Kentaro Hara.

Adds a data member (and getter, setter methods) to V8PerContextData
that holds a pointer to a V8DOMActivityLogger. This member is set while
initializing the context for a V8DOMWindowShell. Ownership of the pointer
is still retained by the HashMap in DOMWrapperWorld.
As a result of this patch, subsequent patches that will implement logging
for DOM API access (See bug 107207) will be able to obtain a reference to
the logger directly from PerContextData. This will benefit performance as it
will be faster than looking up the logger in the DOMActivityLoggerMap in
DOMWrapperWorld.

There are no new tests as there is no change in behavior.

• bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::initializeIfNeeded):

• bindings/v8/V8PerContextData.h:

(WebCore::V8PerContextData::activityLogger):
(V8PerContextData):
(WebCore::V8PerContextData::setActivityLogger):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/v8/V8DOMWindowShell.cpp (modified) (1 diff)
• bindings/v8/V8PerContextData.h (modified) (3 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-03-19  Ankur Taly  <ataly@google.com>
+
+        Cache a pointer to V8DOMActivityLogger in PerContextData.
+        https://bugs.webkit.org/show_bug.cgi?id=112719
+
+        Reviewed by Kentaro Hara.
+
+        Adds a data member (and getter, setter methods) to V8PerContextData
+        that holds a pointer to a V8DOMActivityLogger. This member is set while
+        initializing the context for a V8DOMWindowShell. Ownership of the pointer
+        is still retained by the HashMap in DOMWrapperWorld.
+        As a result of this patch, subsequent patches that will implement logging
+        for DOM API access (See bug 107207) will be able to obtain a reference to
+        the logger directly from PerContextData. This will benefit performance as it
+        will be faster than looking up the logger in the DOMActivityLoggerMap in
+        DOMWrapperWorld.
+
+        There are no new tests as there is no change in behavior.
+
+        * bindings/v8/V8DOMWindowShell.cpp:
+        (WebCore::V8DOMWindowShell::initializeIfNeeded):
+        * bindings/v8/V8PerContextData.h:
+        (WebCore::V8PerContextData::activityLogger):
+        (V8PerContextData):
+        (WebCore::V8PerContextData::setActivityLogger):
+
 2013-03-19  Arnaud Renevier  <a.renevier@sisa.samsung.com>
 

trunk/Source/WebCore/bindings/v8/V8DOMWindowShell.cpp

@@ -240 +240 @@
         return false;
     }
-
+    m_perContextData->setActivityLogger(DOMWrapperWorld::activityLogger(m_world->worldId()));
     if (!installDOMWindow()) {
         disposeContext();

trunk/Source/WebCore/bindings/v8/V8PerContextData.h

@@ -33 +33 @@
 
 #include "ScopedPersistent.h"
+#include "V8DOMActivityLogger.h"
 #include "WrapperTypeInfo.h"
 #include <v8.h>
@@ -94 +95 @@
     }
 
+    V8DOMActivityLogger* activityLogger()
+    {
+        return m_activityLogger;
+    }
+
+    void setActivityLogger(V8DOMActivityLogger* logger)
+    {
+        m_activityLogger = logger;
+    }
+
 private:
     explicit V8PerContextData(v8::Persistent<v8::Context> context)
@@ -114 +125 @@
 
     V8NPObjectMap m_v8NPObjectMap;
-
+    // We cache a pointer to the V8DOMActivityLogger associated with the world
+    // corresponding to this context. The ownership of the pointer is retained
+    // by the DOMActivityLoggerMap in DOMWrapperWorld.
+    V8DOMActivityLogger* m_activityLogger;
     v8::Persistent<v8::Context> m_context;
     ScopedPersistent<v8::Value> m_errorPrototype;