Changeset 146378 in webkit


Ignore:
Timestamp:
Mar 20, 2013, 12:27:19 PM (12 years ago)
Author:
commit-queue@webkit.org
Message:

Remove PlatformEvent::GestureDoubleTap
​https://bugs.webkit.org/show_bug.cgi?id=93045

Patch by Yufeng Shen <​miletus@chromium.org> on 2013-03-20
Reviewed by Antonio Gomes.

Source/WebCore:

PlatformEvent::GestureDoubleTap is not currently
used in WebCore and replaced by GestureTap with
tap count 2, so remove it.

Test: We are removing something that is not used, so
no new test. All existing tests pass.

  • dom/GestureEvent.cpp:

(WebCore::GestureEvent::create):

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleGestureEvent):

  • platform/PlatformEvent.h:
  • platform/chromium/PopupContainer.cpp:

(WebCore::PopupContainer::handleGestureEvent):

Source/WebKit/chromium:

PlatformEvent::GestureDoubleTap is not currently
used in WebCore so remove it.

  • src/WebInputEventConversion.cpp:

(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):

Location:
trunk/Source
Files:
8 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r146377 r146378  
     12013-03-20  Yufeng Shen  <miletus@chromium.org>
     2
     3        Remove PlatformEvent::GestureDoubleTap
     4        https://bugs.webkit.org/show_bug.cgi?id=93045
     5
     6        Reviewed by Antonio Gomes.
     7
     8        PlatformEvent::GestureDoubleTap is not currently
     9        used in WebCore and replaced by GestureTap with
     10        tap count 2, so remove it.
     11
     12        Test: We are removing something that is not used, so
     13        no new test. All existing tests pass.
     14
     15        * dom/GestureEvent.cpp:
     16        (WebCore::GestureEvent::create):
     17        * page/EventHandler.cpp:
     18        (WebCore::EventHandler::handleGestureEvent):
     19        * platform/PlatformEvent.h:
     20        * platform/chromium/PopupContainer.cpp:
     21        (WebCore::PopupContainer::handleGestureEvent):
     22
    1232013-03-20  Ojan Vafai  <ojan@chromium.org>
    224

  • trunk/Source/WebCore/dom/GestureEvent.cpp

    r145524 r146378  
    5454    case PlatformEvent::GestureTapDown:
    5555        eventType = eventNames().gesturetapdownEvent; break;
    56     case PlatformEvent::GestureDoubleTap:
    5756    case PlatformEvent::GestureTwoFingerTap:
    5857    case PlatformEvent::GestureLongPress:

  • trunk/Source/WebCore/page/EventHandler.cpp

    r146224 r146378  
    24552455bool EventHandler::handleGestureEvent(const PlatformGestureEvent& gestureEvent)
    24562456{
    2457     // We don't use DoubleTap at the moment, it's mostly redundant with tap since tap now contains
    2458     // a tap count. FIXME: We should probably remove GestureDoubleTap (http://wkb.ug/93045).
    2459     if (gestureEvent.type() == PlatformEvent::GestureDoubleTap)
    2460         return false;
    2461 
    24622457    Node* eventTarget = 0;
    24632458    Scrollbar* scrollbar = 0;
    … …  
    25462541    case PlatformEvent::GestureTwoFingerTap:
    25472542        return handleGestureTwoFingerTap(gestureEvent);
    2548     case PlatformEvent::GestureDoubleTap:
    25492543    case PlatformEvent::GesturePinchBegin:
    25502544    case PlatformEvent::GesturePinchEnd:

  • trunk/Source/WebCore/platform/PlatformEvent.h

    r142057 r146378  
    5757        GestureTapDown,
    5858        GestureTapDownCancel,
    59         GestureDoubleTap,
    6059        GestureTwoFingerTap,
    6160        GestureLongPress,

  • trunk/Source/WebCore/platform/chromium/PopupContainer.cpp

    r145453 r146378  
    320320        return true;
    321321    }
    322     case PlatformEvent::GestureDoubleTap:
    323         break;
    324322    case PlatformEvent::GestureScrollUpdate:
    325323    case PlatformEvent::GestureScrollUpdateWithoutPropagation: {

  • trunk/Source/WebKit/chromium/ChangeLog

    r146351 r146378  
     12013-03-20  Yufeng Shen  <miletus@chromium.org>
     2
     3        Remove PlatformEvent::GestureDoubleTap
     4        https://bugs.webkit.org/show_bug.cgi?id=93045
     5
     6        Reviewed by Antonio Gomes.
     7
     8        PlatformEvent::GestureDoubleTap is not currently
     9        used in WebCore so remove it.
     10
     11        * src/WebInputEventConversion.cpp:
     12        (WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
     13
    1142013-03-20  Justin Novosad  <junov@google.com>
    215

  • trunk/Source/WebKit/chromium/src/WebInputEventConversion.cpp

    r143032 r146378  
    187187        m_type = PlatformEvent::GestureTapDownCancel;
    188188        break;
    189     case WebInputEvent::GestureDoubleTap:
    190         m_type = PlatformEvent::GestureDoubleTap;
    191         break;
    192189    case WebInputEvent::GestureTwoFingerTap:
    193190        m_type = PlatformEvent::GestureTwoFingerTap;

  • trunk/Source/WebKit/chromium/src/WebViewImpl.cpp

    r146091 r146378  
    828828            m_client->cancelScheduledContentIntents();
    829829            animateZoomAroundPoint(platformEvent.position(), DoubleTap);
    830             eventSwallowed = true;
    831             break;
    832830        }
     831        // GestureDoubleTap is currently only used by Android for zooming. For WebCore,
     832        // GestureTap with tap count = 2 is used instead. So we drop GestureDoubleTap here.
     833        eventSwallowed = true;
     834        break;
    833835    case WebInputEvent::GestureScrollBegin:
    834836    case WebInputEvent::GesturePinchBegin:
Note: See TracChangeset for help on using the changeset viewer.