Changeset 146457 in webkit


Ignore:
Timestamp:
Mar 21, 2013, 5:58:22 AM (12 years ago)
Author:
commit-queue@webkit.org
Message:

Unreviewed, rolling out r146454.
​http://trac.webkit.org/changeset/146454
​https://bugs.webkit.org/show_bug.cgi?id=112906

compile failures (Requested by antonm on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-03-21

Source/WebCore:

  • WebCore.gypi:
  • platform/graphics/filters/FEConvolveMatrix.h:

(FEConvolveMatrix):

  • platform/graphics/filters/skia/FEConvolveMatrixSkia.cpp: Removed.

LayoutTests:

  • css3/filters/effect-reference-hw.html:
  • css3/filters/effect-reference.html:
  • platform/chromium/TestExpectations:
Location:
trunk
Files:
1 deleted
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r146455 r146457  
     12013-03-21  Sheriff Bot  <webkit.review.bot@gmail.com>
     2
     3        Unreviewed, rolling out r146454.
     4        http://trac.webkit.org/changeset/146454
     5        https://bugs.webkit.org/show_bug.cgi?id=112906
     6
     7        compile failures (Requested by antonm on #webkit).
     8
     9        * css3/filters/effect-reference-hw.html:
     10        * css3/filters/effect-reference.html:
     11        * platform/chromium/TestExpectations:
     12
    1132013-03-21  Anton Muhin  <antonm@chromium.org>
    214

  • trunk/LayoutTests/css3/filters/effect-reference-hw.html

    r146454 r146457  
    3232      <feOffset dx="10" dy="10"/>
    3333    </filter>
    34     <filter id="convolvematrix">
    35       <feConvolveMatrix order="3 3" kernelMatrix="1 1 1   1 -7 1   1 1 1" bias ="0.3"/>
    36     </filter>
    3734  </defs>
    3835</svg>
    … …  
    5148<img style="-webkit-filter: url(#lighting); filter: url(#lighting);" src="resources/reference.png">
    5249<img style="-webkit-filter: url(#offset); filter: url(#offset);" src="resources/reference.png">
    53 <img style="-webkit-filter: url(#convolvematrix); filter: url(#convolvematrix);" src="resources/reference.png">

  • trunk/LayoutTests/css3/filters/effect-reference.html

    r146454 r146457  
    3232      <feOffset dx="10" dy="10"/>
    3333    </filter>
    34     <filter id="convolvematrix">
    35       <feConvolveMatrix order="3 3" kernelMatrix="1 1 1   1 -7 1   1 1 1" bias ="0.3"/>
    36     </filter>
    3734  </defs>
    3835</svg>
    … …  
    5047<img style="-webkit-filter: url(#lighting); filter: url(#lighting);" src="resources/reference.png">
    5148<img style="-webkit-filter: url(#offset); filter: url(#offset);" src="resources/reference.png">
    52 <img style="-webkit-filter: url(#convolvematrix); filter: url(#convolvematrix);" src="resources/reference.png">

  • trunk/LayoutTests/platform/chromium/TestExpectations

    r146455 r146457  
    119119# Has been timing out intermittently for a long time.
    120120webkit.org/b/101236 [ Debug ] css3/filters/custom/custom-filter-animation.html [ Pass Timeout ]
    121 
    122 # Needs rebaseline
    123 webkit.org/b/112828 css3/filters/effect-reference.html [ Failure ImageOnlyFailure Pass ]
    124 webkit.org/b/112828 css3/filters/effect-reference-hw.html [ Failure ImageOnlyFailure Pass ]
    125121
    126122# Has been failing since r133544-133546

  • trunk/Source/WebCore/ChangeLog

    r146456 r146457  
     12013-03-21  Sheriff Bot  <webkit.review.bot@gmail.com>
     2
     3        Unreviewed, rolling out r146454.
     4        http://trac.webkit.org/changeset/146454
     5        https://bugs.webkit.org/show_bug.cgi?id=112906
     6
     7        compile failures (Requested by antonm on #webkit).
     8
     9        * WebCore.gypi:
     10        * platform/graphics/filters/FEConvolveMatrix.h:
     11        (FEConvolveMatrix):
     12        * platform/graphics/filters/skia/FEConvolveMatrixSkia.cpp: Removed.
     13
    1142013-03-21  Mike Reed  <reed@google.com>
    215

  • trunk/Source/WebCore/WebCore.gypi

    r146454 r146457  
    41684168            'platform/graphics/filters/skia/FEColorMatrixSkia.cpp',
    41694169            'platform/graphics/filters/skia/FEComponentTransferSkia.cpp',
    4170             'platform/graphics/filters/skia/FEConvolveMatrixSkia.cpp',
    41714170            'platform/graphics/filters/skia/FEGaussianBlurSkia.cpp',
    41724171            'platform/graphics/filters/skia/FEMorphologySkia.cpp',

  • trunk/Source/WebCore/platform/graphics/filters/FEConvolveMatrix.h

    r146454 r146457  
    7272
    7373    virtual void platformApplySoftware();
    74 #if USE(SKIA)
    75     virtual SkImageFilter* createImageFilter(SkiaImageFilterBuilder*);
    76 #endif
    7774    virtual void dump();
    7875
Note: See TracChangeset for help on using the changeset viewer.