Changeset 147832 in webkit

Timestamp:

Apr 5, 2013, 9:41:38 PM (12 years ago)

Author:

kangil.han@samsung.com

Message:

Prefer prefix ++/-- operators for non-primitive types
​https://bugs.webkit.org/show_bug.cgi?id=114033

Reviewed by Alexey Proskuryakov.

Post ++/-- creates a copy of current value and it is not necessary, so use prefix instead.

• bindings/js/Dictionary.cpp:

(WebCore::Dictionary::getOwnPropertiesAsStringHashMap):
(WebCore::Dictionary::getOwnPropertyNames):

• bindings/js/ScriptCallStackFactory.cpp:

(WebCore::createScriptCallStack):

• dom/ContainerNode.cpp:

(WebCore::willRemoveChildren):

• dom/Range.cpp:

(WebCore::Range::processAncestorsAndTheirSiblings):

• loader/FrameLoader.cpp:

(WebCore::FrameLoader::detachChildren):

• platform/graphics/gpu/LoopBlinnPathProcessor.cpp:

(WebCore):
(WebCore::LoopBlinnPathProcessor::subdivideCurvesSlow):

• rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintDocumentMarkers):

• xml/XPathFunctions.cpp:

(WebCore::XPath::Function::setArguments):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/js/Dictionary.cpp (modified) (2 diffs)
• dom/ContainerNode.cpp (modified) (1 diff)
• dom/Range.cpp (modified) (2 diffs)
• loader/FrameLoader.cpp (modified) (1 diff)
• platform/graphics/gpu/LoopBlinnPathProcessor.cpp (modified) (1 diff)
• rendering/InlineTextBox.cpp (modified) (1 diff)
• xml/XPathFunctions.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-04-05  Kangil Han  <kangil.han@samsung.com>
+
+        Prefer prefix ++/-- operators for non-primitive types
+        https://bugs.webkit.org/show_bug.cgi?id=114033
+
+        Reviewed by Alexey Proskuryakov.
+
+        Post ++/-- creates a copy of current value and it is not necessary, so use prefix instead.
+
+        * bindings/js/Dictionary.cpp:
+        (WebCore::Dictionary::getOwnPropertiesAsStringHashMap):
+        (WebCore::Dictionary::getOwnPropertyNames):
+        * bindings/js/ScriptCallStackFactory.cpp:
+        (WebCore::createScriptCallStack):
+        * dom/ContainerNode.cpp:
+        (WebCore::willRemoveChildren):
+        * dom/Range.cpp:
+        (WebCore::Range::processAncestorsAndTheirSiblings):
+        * loader/FrameLoader.cpp:
+        (WebCore::FrameLoader::detachChildren):
+        * platform/graphics/gpu/LoopBlinnPathProcessor.cpp:
+        (WebCore):
+        (WebCore::LoopBlinnPathProcessor::subdivideCurvesSlow):
+        * rendering/InlineTextBox.cpp:
+        (WebCore::InlineTextBox::paintDocumentMarkers):
+        * xml/XPathFunctions.cpp:
+        (WebCore::XPath::Function::setArguments):
+
 2013-04-05  Hans Muller  <hmuller@adobe.com>
 

trunk/Source/WebCore/bindings/js/Dictionary.cpp

@@ -65 +65 @@
     PropertyNameArray propertyNames(exec);
     JSObject::getOwnPropertyNames(object, exec, propertyNames, ExcludeDontEnumProperties);
-    for (PropertyNameArray::const_iterator it = propertyNames.begin(); it != propertyNames.end(); it++) {
+    for (PropertyNameArray::const_iterator it = propertyNames.begin(); it != propertyNames.end(); ++it) {
         String stringKey = it->string();
         if (stringKey.isEmpty())
@@ -90 +90 @@
     PropertyNameArray propertyNames(exec);
     JSObject::getOwnPropertyNames(object, exec, propertyNames, ExcludeDontEnumProperties);
-    for (PropertyNameArray::const_iterator it = propertyNames.begin(); it != propertyNames.end(); it++) {
+    for (PropertyNameArray::const_iterator it = propertyNames.begin(); it != propertyNames.end(); ++it) {
         String stringKey = it->string();
         if (!stringKey.isEmpty())

trunk/Source/WebCore/dom/ContainerNode.cpp

@@ -463 +463 @@
 
     ChildListMutationScope mutation(container);
-    for (NodeVector::const_iterator it = children.begin(); it != children.end(); it++) {
+    for (NodeVector::const_iterator it = children.begin(); it != children.end(); ++it) {
         Node* child = it->get();
         mutation.willRemoveChild(child);

trunk/Source/WebCore/dom/Range.cpp

@@ -874 +874 @@
 
     RefPtr<Node> firstChildInAncestorToProcess = direction == ProcessContentsForward ? container->nextSibling() : container->previousSibling();
-    for (Vector<RefPtr<Node> >::const_iterator it = ancestors.begin(); it != ancestors.end(); it++) {
+    for (Vector<RefPtr<Node> >::const_iterator it = ancestors.begin(); it != ancestors.end(); ++it) {
         RefPtr<Node> ancestor = *it;
         if (action == EXTRACT_CONTENTS || action == CLONE_CONTENTS) {
@@ -893 +893 @@
             nodes.append(child);
 
-        for (NodeVector::const_iterator it = nodes.begin(); it != nodes.end(); it++) {
+        for (NodeVector::const_iterator it = nodes.begin(); it != nodes.end(); ++it) {
             Node* child = it->get();
             switch (action) {

trunk/Source/WebCore/loader/FrameLoader.cpp

@@ -2306 +2306 @@
         childrenToDetach.append(child);
     FrameVector::iterator end = childrenToDetach.end();
-    for (FrameVector::iterator it = childrenToDetach.begin(); it != end; it++)
+    for (FrameVector::iterator it = childrenToDetach.begin(); it != end; ++it)
         (*it)->loader()->detachFromParent();
 }

trunk/Source/WebCore/platform/graphics/gpu/LoopBlinnPathProcessor.cpp

@@ -1099 +1099 @@
             Segment* seg = *iter;
             ASSERT(seg->kind() == Segment::Cubic);
-            for (Vector<Segment*>::iterator iter2 = curSegments.begin();
-                 iter2 != curSegments.end();
-                 iter2++) {
+            for (Vector<Segment*>::iterator iter2 = curSegments.begin(); iter2 != curSegments.end(); ++iter2) {
                 Segment* seg2 = *iter2;
                 ASSERT(seg2->kind() == Segment::Cubic);

trunk/Source/WebCore/rendering/InlineTextBox.cpp

@@ -1399 +1399 @@
     // Give any document markers that touch this run a chance to draw before the text has been drawn.
     // Note end() points at the last char, not one past it like endOffset and ranges do.
-    for ( ; markerIt != markers.end(); markerIt++) {
+    for ( ; markerIt != markers.end(); ++markerIt) {
         DocumentMarker* marker = *markerIt;
         

trunk/Source/WebCore/xml/XPathFunctions.cpp

@@ -300 +300 @@
 
     Vector<Expression*>::const_iterator end = args.end();
-    for (Vector<Expression*>::const_iterator it = args.begin(); it != end; it++)
+    for (Vector<Expression*>::const_iterator it = args.begin(); it != end; ++it)
         addSubExpression(*it);
 }