Changeset 149474 in webkit

Timestamp:

May 1, 2013 6:48:55 PM (11 years ago)

Author:

enrica@apple.com

Message:

text-combine: horizontal does not work properly for some fonts.
​https://bugs.webkit.org/show_bug.cgi?id=115503.

Reviewed by Dave Hyatt.

Source/WebCore:

For some fonts that don't have width variants, we fail to combine glyphs
because we believe they don't fit. That decision is made comparing the run width
with the font computed size multiplied by a margin factor.
I've increased the margin from 10% to 15%.

Test: fast/text/text-combine-different-fonts.html

• rendering/RenderCombineText.cpp:

LayoutTests:

• fast/text/text-combine-different-fonts.html: Added.
• platform/mac/fast/text/text-combine-different-fonts-expected.png: Added.
• platform/mac/fast/text/text-combine-different-fonts-expected.txt: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/text/text-combine-different-fonts.html (added)
• LayoutTests/platform/mac/fast/text/text-combine-different-fonts-expected.png (added)
• LayoutTests/platform/mac/fast/text/text-combine-different-fonts-expected.txt (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderCombineText.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-05-01  Enrica Casucci  <enrica@apple.com>
+
+        text-combine: horizontal does not work properly for some fonts.
+        https://bugs.webkit.org/show_bug.cgi?id=115503.
+
+        Reviewed by Dave Hyatt.
+
+        * fast/text/text-combine-different-fonts.html: Added.
+        * platform/mac/fast/text/text-combine-different-fonts-expected.png: Added.
+        * platform/mac/fast/text/text-combine-different-fonts-expected.txt: Added.
+
 2013-05-01  Stephanie Lewis  <slewis@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-05-01  Enrica Casucci  <enrica@apple.com>
+
+        text-combine: horizontal does not work properly for some fonts.
+        https://bugs.webkit.org/show_bug.cgi?id=115503.
+
+        Reviewed by Dave Hyatt.
+
+        For some fonts that don't have width variants, we fail to combine glyphs
+        because we believe they don't fit. That decision is made comparing the run width
+        with the font computed size multiplied by a margin factor.
+        I've increased the margin from 10% to 15%.
+         
+        Test: fast/text/text-combine-different-fonts.html
+
+        * rendering/RenderCombineText.cpp:
+
 2013-05-01  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/WebCore/rendering/RenderCombineText.cpp

@@ -27 +27 @@
 namespace WebCore {
 
-const float textCombineMargin = 1.1f; // Allow em + 10% margin
+const float textCombineMargin = 1.15f; // Allow em + 15% margin
 
 RenderCombineText::RenderCombineText(Node* node, PassRefPtr<StringImpl> string)