Changeset 154666 in webkit

Timestamp:

Aug 27, 2013 12:26:28 AM (11 years ago)

Author:

calvaris@igalia.com

Message:

[GTK] Volume slider shows incorrect track when muted
​https://bugs.webkit.org/show_bug.cgi?id=120253

Reviewed by Philippe Normand.

When painting the volume bar, consider that it could be muted even
then volume is different than zero.

• platform/gtk/RenderThemeGtk.cpp:

(WebCore::RenderThemeGtk::paintMediaVolumeSliderTrack): Asign
painted volume as 0 when media is muted.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/gtk/RenderThemeGtk.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-08-27  Xabier Rodriguez Calvar  <calvaris@igalia.com>
+
+        [GTK] Volume slider shows incorrect track when muted
+        https://bugs.webkit.org/show_bug.cgi?id=120253
+
+        Reviewed by Philippe Normand.
+
+        When painting the volume bar, consider that it could be muted even
+        then volume is different than zero.
+
+        * platform/gtk/RenderThemeGtk.cpp:
+        (WebCore::RenderThemeGtk::paintMediaVolumeSliderTrack): Asign
+        painted volume as 0 when media is muted.
+
 2013-08-26  Sam Weinig  <sam@webkit.org>
 

trunk/Source/WebCore/platform/gtk/RenderThemeGtk.cpp

@@ -605 +605 @@
         return true;
 
-    float volume = mediaElement->volume();
+    float volume = mediaElement->muted() ? 0.0f : mediaElement->volume();
     if (!volume)
         return true;