Changeset 155018 in webkit

Timestamp:

Sep 3, 2013 9:49:23 PM (11 years ago)

Author:

akling@apple.com

Message:

ASSERTION FAILED: frame().view() == this closing a page with SVG or video
<​https://webkit.org/b/120645>

Reviewed by Antti Koivisto.

Have RenderSVGResourceContainer check if the document is being destroyed before
triggering any repaints. This replaces the previous check for a null RenderView
which meant basically the same thing.

We could add more and better assertions to catch unnecessary work during tree
teardown, but let's do that separately.

• rendering/svg/RenderSVGResourceContainer.cpp:

(WebCore::RenderSVGResourceContainer::markClientForInvalidation):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/svg/RenderSVGResourceContainer.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-09-03  Andreas Kling  <akling@apple.com>
+
+        ASSERTION FAILED: frame().view() == this closing a page with SVG or video
+        <https://webkit.org/b/120645>
+
+        Reviewed by Antti Koivisto.
+
+        Have RenderSVGResourceContainer check if the document is being destroyed before
+        triggering any repaints. This replaces the previous check for a null RenderView
+        which meant basically the same thing.
+
+        We could add more and better assertions to catch unnecessary work during tree
+        teardown, but let's do that separately.
+
+        * rendering/svg/RenderSVGResourceContainer.cpp:
+        (WebCore::RenderSVGResourceContainer::markClientForInvalidation):
+
 2013-09-03  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
 

trunk/Source/WebCore/rendering/svg/RenderSVGResourceContainer.cpp

@@ -140 +140 @@
         break;
     case RepaintInvalidation:
-        client->repaint();
+        if (!client->documentBeingDestroyed())
+            client->repaint();
         break;
     case ParentOnlyInvalidation: