Changeset 155348 in webkit

Timestamp:

Sep 9, 2013, 6:58:13 AM (13 years ago)

Author:

allan.jensen@digia.com

Message:

MouseLeave not always emitted when cursor leaves subframe
​https://bugs.webkit.org/show_bug.cgi?id=121026

Reviewed by Antonio Gomes.

Source/WebCore:

Forward the PlatformMouseEvent in the recursive calls so nested documents
also get a chance to emit mouseleave when the hover moves out.

Test: fast/events/mouseenterleave-on-subframe.html

• dom/Document.cpp:

(WebCore::Document::updateHoverActiveState):

LayoutTests:

Test or mouseenter/mouseleave events in an inner document. Note this test also
tests bug 120862, but the initial expectations assume that part to fail.

• fast/events/mouseenterleave-on-subframe-expected.html: Added.
• fast/events/mouseenterleave-on-subframe.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/events/mouseenterleave-on-subframe-expected.html (added)
• LayoutTests/fast/events/mouseenterleave-on-subframe.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/dom/Document.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-09-09  Allan Sandfeld Jensen  <allan.jensen@digia.com>
+
+        MouseLeave not always emitted when cursor leaves subframe
+        https://bugs.webkit.org/show_bug.cgi?id=121026
+
+        Reviewed by Antonio Gomes.
+
+        Test or mouseenter/mouseleave events in an inner document. Note this test also
+        tests bug 120862, but the initial expectations assume that part to fail.
+
+        * fast/events/mouseenterleave-on-subframe-expected.html: Added.
+        * fast/events/mouseenterleave-on-subframe.html: Added.
+
 2013-09-09  Krzysztof Czech  <k.czech@samsung.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-09-09  Allan Sandfeld Jensen  <allan.jensen@digia.com>
+
+        MouseLeave not always emitted when cursor leaves subframe
+        https://bugs.webkit.org/show_bug.cgi?id=121026
+
+        Reviewed by Antonio Gomes.
+
+        Forward the PlatformMouseEvent in the recursive calls so nested documents
+        also get a chance to emit mouseleave when the hover moves out.
+
+        Test: fast/events/mouseenterleave-on-subframe.html
+
+        * dom/Document.cpp:
+        (WebCore::Document::updateHoverActiveState):
+
 2013-09-09  Thiago de Barros Lacerda  <thiago.lacerda@openbossa.org>
 

trunk/Source/WebCore/dom/Document.cpp

@@ -5760 +5760 @@
     Element* innerElementInDocument = innerElement;
     while (innerElementInDocument && &innerElementInDocument->document() != this) {
-        innerElementInDocument->document().updateHoverActiveState(request, innerElementInDocument);
+        innerElementInDocument->document().updateHoverActiveState(request, innerElementInDocument, event);
         innerElementInDocument = innerElementInDocument->document().ownerElement();
     }
@@ -5864 +5864 @@
         if (oldHoveredElement && oldHoveredElement->isFrameOwnerElement()) {
             if (Document* contentDocument = toFrameOwnerElement(oldHoveredElement.get())->contentDocument())
-                contentDocument->updateHoverActiveState(request, 0);
+                contentDocument->updateHoverActiveState(request, 0, event);
         }
     }