Changeset 155421 in webkit
- Timestamp:
- Sep 9, 2013, 11:10:17 PM (13 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 5 edited
-
ChangeLog (modified) (1 diff)
-
page/Frame.cpp (modified) (1 diff)
-
page/animation/AnimationController.cpp (modified) (8 diffs)
-
page/animation/AnimationController.h (modified) (2 diffs)
-
page/animation/AnimationControllerPrivate.h (modified) (2 diffs)
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r155419 r155421 1 2013-09-09 Andreas Kling <akling@apple.com> 2 3 Remove unreviewed gunk I just accidentally committed :| 4 1 5 2013-09-09 Andreas Kling <akling@apple.com> 2 6 -
trunk/Source/WebCore/page/Frame.cpp
r155419 r155421 162 162 , m_selection(adoptPtr(new FrameSelection(this))) 163 163 , m_eventHandler(adoptPtr(new EventHandler(*this))) 164 , m_animationController( createOwned<AnimationController>(*this)))164 , m_animationController(adoptPtr(new AnimationController(this))) 165 165 , m_pageZoomFactor(parentPageZoomFactor(this)) 166 166 , m_textZoomFactor(parentTextZoomFactor(this)) -
trunk/Source/WebCore/page/animation/AnimationController.cpp
r155419 r155421 51 51 static const double cBeginAnimationUpdateTimeNotSet = -1; 52 52 53 AnimationControllerPrivate::AnimationControllerPrivate(Frame &frame)53 AnimationControllerPrivate::AnimationControllerPrivate(Frame* frame) 54 54 : m_animationTimer(this, &AnimationControllerPrivate::animationTimerFired) 55 55 , m_updateStyleIfNeededDispatcher(this, &AnimationControllerPrivate::updateStyleIfNeededDispatcherFired) … … 113 113 114 114 if (calledSetChanged) 115 m_frame .document()->updateStyleIfNeeded();115 m_frame->document()->updateStyleIfNeeded(); 116 116 117 117 return timeToNextService; … … 164 164 { 165 165 // Protect the frame from getting destroyed in the event handler 166 Ref <Frame> protector(m_frame);166 RefPtr<Frame> protector = m_frame; 167 167 168 168 bool updateStyle = !m_eventsToDispatch.isEmpty() || !m_nodeChangesToDispatch.isEmpty(); … … 187 187 m_nodeChangesToDispatch.clear(); 188 188 189 if (updateStyle )190 m_frame .document()->updateStyleIfNeeded();189 if (updateStyle && m_frame) 190 m_frame->document()->updateStyleIfNeeded(); 191 191 } 192 192 … … 225 225 226 226 if (timeToNextService >= 0) 227 m_frame .document()->view()->scheduleAnimation();227 m_frame->document()->view()->scheduleAnimation(); 228 228 } 229 229 #endif … … 267 267 return; 268 268 269 suspendAnimationsForDocument(m_frame .document());269 suspendAnimationsForDocument(m_frame->document()); 270 270 271 271 // Traverse subframes 272 for (Frame* child = m_frame .tree().firstChild(); child; child = child->tree().nextSibling())272 for (Frame* child = m_frame->tree().firstChild(); child; child = child->tree().nextSibling()) 273 273 child->animation().suspendAnimations(); 274 274 … … 281 281 return; 282 282 283 resumeAnimationsForDocument(m_frame .document());283 resumeAnimationsForDocument(m_frame->document()); 284 284 285 285 // Traverse subframes 286 for (Frame* child = m_frame .tree().firstChild(); child; child = child->tree().nextSibling())286 for (Frame* child = m_frame->tree().firstChild(); child; child = child->tree().nextSibling()) 287 287 child->animation().resumeAnimations(); 288 288 … … 491 491 } 492 492 493 AnimationController::AnimationController(Frame &frame)494 : m_data( createOwned<AnimationControllerPrivate>(frame)))493 AnimationController::AnimationController(Frame* frame) 494 : m_data(adoptPtr(new AnimationControllerPrivate(frame))) 495 495 , m_beginAnimationUpdateCount(0) 496 496 { -
trunk/Source/WebCore/page/animation/AnimationController.h
r155419 r155421 47 47 class AnimationController { 48 48 public: 49 explicit AnimationController(Frame&);49 AnimationController(Frame*); 50 50 ~AnimationController(); 51 51 … … 84 84 85 85 private: 86 constOwnPtr<AnimationControllerPrivate> m_data;86 OwnPtr<AnimationControllerPrivate> m_data; 87 87 int m_beginAnimationUpdateCount; 88 88 }; -
trunk/Source/WebCore/page/animation/AnimationControllerPrivate.h
r155419 r155421 59 59 WTF_MAKE_NONCOPYABLE(AnimationControllerPrivate); WTF_MAKE_FAST_ALLOCATED; 60 60 public: 61 explicit AnimationControllerPrivate(Frame&);61 AnimationControllerPrivate(Frame*); 62 62 ~AnimationControllerPrivate(); 63 63 … … 126 126 Timer<AnimationControllerPrivate> m_animationTimer; 127 127 Timer<AnimationControllerPrivate> m_updateStyleIfNeededDispatcher; 128 Frame &m_frame;128 Frame* m_frame; 129 129 130 130 class EventToDispatch {
Note:
See TracChangeset
for help on using the changeset viewer.