Changeset 155422 in webkit

Timestamp:

Sep 9, 2013, 11:16:47 PM (13 years ago)

Author:

commit-queue@webkit.org

Message:

Adding "explicit" keyword in DOM related classes constructor
​https://bugs.webkit.org/show_bug.cgi?id=121031

Patch by Santosh Mahto <​santosh.ma@samsung.com> on 2013-09-09
Reviewed by Ryosuke Niwa.

Added the explicit keyword in constructors.

• dom/ActiveDOMObject.h:
• dom/ContainerNode.h:
• dom/DocumentStyleSheetCollection.h:
• dom/ElementAncestorIterator.h:
• dom/ElementData.h:
• dom/ElementRareData.h:
• dom/EventListenerMap.h:
• dom/QualifiedName.h:

(WebCore::QualifiedName::QualifiedName):

• dom/TreeScope.h:
• dom/ViewportArguments.h:

(WebCore::ViewportArguments::ViewportArguments):

• dom/VisitedLinkState.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• dom/ActiveDOMObject.h (modified) (1 diff)
• dom/ContainerNode.h (modified) (1 diff)
• dom/DocumentStyleSheetCollection.h (modified) (1 diff)
• dom/ElementAncestorIterator.h (modified) (4 diffs)
• dom/ElementData.h (modified) (1 diff)
• dom/ElementRareData.h (modified) (1 diff)
• dom/EventListenerMap.h (modified) (1 diff)
• dom/QualifiedName.h (modified) (1 diff)
• dom/TreeScope.h (modified) (1 diff)
• dom/ViewportArguments.h (modified) (1 diff)
• dom/VisitedLinkState.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-09-09  Santosh Mahto  <santosh.ma@samsung.com>
+
+        Adding "explicit" keyword in DOM related classes constructor
+        https://bugs.webkit.org/show_bug.cgi?id=121031
+
+        Reviewed by Ryosuke Niwa.
+
+        Added the explicit keyword in constructors.
+
+        * dom/ActiveDOMObject.h:
+        * dom/ContainerNode.h:
+        * dom/DocumentStyleSheetCollection.h:
+        * dom/ElementAncestorIterator.h:
+        * dom/ElementData.h:
+        * dom/ElementRareData.h:
+        * dom/EventListenerMap.h:
+        * dom/QualifiedName.h:
+        (WebCore::QualifiedName::QualifiedName):
+        * dom/TreeScope.h:
+        * dom/ViewportArguments.h:
+        (WebCore::ViewportArguments::ViewportArguments):
+        * dom/VisitedLinkState.h:
+
 2013-09-09  Andreas Kling  <akling@apple.com>
 

trunk/Source/WebCore/dom/ActiveDOMObject.h

@@ -36 +36 @@
 class ActiveDOMObject : public ContextDestructionObserver {
 public:
-    ActiveDOMObject(ScriptExecutionContext*);
+    explicit ActiveDOMObject(ScriptExecutionContext*);
 
     // suspendIfNeeded() should be called exactly once after object construction to synchronize

trunk/Source/WebCore/dom/ContainerNode.h

@@ -125 +125 @@
 
 protected:
-    ContainerNode(Document*, ConstructionType = CreateContainer);
+    explicit ContainerNode(Document*, ConstructionType = CreateContainer);
 
     static void queuePostAttachCallback(NodeCallback, Node*, unsigned = 0);

trunk/Source/WebCore/dom/DocumentStyleSheetCollection.h

@@ -119 +119 @@
 
 private:
-    DocumentStyleSheetCollection(Document*);
+    explicit DocumentStyleSheetCollection(Document*);
 
     void collectActiveStyleSheets(Vector<RefPtr<StyleSheet> >&);

trunk/Source/WebCore/dom/ElementAncestorIterator.h

@@ -35 +35 @@
 public:
     ElementAncestorIterator();
-    ElementAncestorIterator(ElementType* current);
+    explicit ElementAncestorIterator(ElementType* current);
     ElementAncestorIterator& operator++();
 };
@@ -43 +43 @@
 public:
     ElementAncestorConstIterator();
-    ElementAncestorConstIterator(const ElementType* current);
+    explicit ElementAncestorConstIterator(const ElementType* current);
     ElementAncestorConstIterator& operator++();
 };
@@ -50 +50 @@
 class ElementAncestorIteratorAdapter {
 public:
-    ElementAncestorIteratorAdapter(ElementType* descendant);
+    explicit ElementAncestorIteratorAdapter(ElementType* descendant);
     ElementAncestorIterator<ElementType> begin();
     ElementAncestorIterator<ElementType> end();
@@ -61 +61 @@
 class ElementAncestorConstIteratorAdapter {
 public:
-    ElementAncestorConstIteratorAdapter(const ElementType* descendant);
+    explicit ElementAncestorConstIteratorAdapter(const ElementType* descendant);
     ElementAncestorConstIterator<ElementType> begin() const;
     ElementAncestorConstIterator<ElementType> end() const;

trunk/Source/WebCore/dom/ElementData.h

@@ -76 +76 @@
 protected:
     ElementData();
-    ElementData(unsigned arraySize);
+    explicit ElementData(unsigned arraySize);
     ElementData(const ElementData&, bool isUnique);
 

trunk/Source/WebCore/dom/ElementRareData.h

@@ -167 +167 @@
     RefPtr<PseudoElement> m_afterPseudoElement;
 
-    ElementRareData(RenderObject*);
+    explicit ElementRareData(RenderObject*);
     void releasePseudoElement(PseudoElement*);
 };

trunk/Source/WebCore/dom/EventListenerMap.h

@@ -80 +80 @@
 public:
     EventListenerIterator();
-    EventListenerIterator(EventTarget*);
+    explicit EventListenerIterator(EventTarget*);
 #ifndef NDEBUG
     ~EventListenerIterator();

trunk/Source/WebCore/dom/QualifiedName.h

@@ -67 +67 @@
 
     QualifiedName(const AtomicString& prefix, const AtomicString& localName, const AtomicString& namespaceURI);
-    QualifiedName(WTF::HashTableDeletedValueType) : m_impl(hashTableDeletedValue()) { }
+    explicit QualifiedName(WTF::HashTableDeletedValueType) : m_impl(hashTableDeletedValue()) { }
     bool isHashTableDeletedValue() const { return m_impl == hashTableDeletedValue(); }
     ~QualifiedName();

trunk/Source/WebCore/dom/TreeScope.h

@@ -134 +134 @@
 protected:
     TreeScope(ContainerNode*, Document*);
-    TreeScope(Document*);
+    explicit TreeScope(Document*);
     virtual ~TreeScope();
 

trunk/Source/WebCore/dom/ViewportArguments.h

@@ -76 +76 @@
     };
 
-    ViewportArguments(Type type = Implicit)
+    explicit ViewportArguments(Type type = Implicit)
         : type(type)
         , width(ValueAuto)

trunk/Source/WebCore/dom/VisitedLinkState.h

@@ -51 +51 @@
 
 private:
-    VisitedLinkState(Document*);
+    explicit VisitedLinkState(Document*);
 
     EInsideLink determineLinkStateSlowCase(Element*);