Changeset 156449 in webkit

Timestamp:

Sep 25, 2013, 11:33:18 PM (13 years ago)

Author:

commit-queue@webkit.org

Message:

8 bytes memory leaks in WebProcessMainQt.cpp when proxy is initialized
​https://bugs.webkit.org/show_bug.cgi?id=118515

Patch by Minju Kim <​pmuarteo@gmail.com> on 2013-09-25
Reviewed by Christophe Dumez.

• WebProcess/qt/WebProcessMainQt.cpp:

(WebKit::initializeProxy): Handled EnvHttpProxyFactory by using OwnPtr
to avoid memory leak when it isn't handled by NetworkProxyFactory

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/qt/WebProcessMainQt.cpp (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2013-09-25  Minju Kim  <pmuarteo@gmail.com>
+
+        8 bytes memory leaks in WebProcessMainQt.cpp when proxy is initialized
+        https://bugs.webkit.org/show_bug.cgi?id=118515
+
+        Reviewed by Christophe Dumez.
+
+        * WebProcess/qt/WebProcessMainQt.cpp:
+        (WebKit::initializeProxy): Handled EnvHttpProxyFactory by using OwnPtr
+        to avoid memory leak when it isn't handled by NetworkProxyFactory
+
 2013-09-25  Brady Eidson  <beidson@apple.com>
 

trunk/Source/WebKit2/WebProcess/qt/WebProcessMainQt.cpp

@@ -133 +133 @@
         QNetworkProxy proxy = proxylist.first();
         if (proxy == QNetworkProxy::NoProxy || proxy == QNetworkProxy::DefaultProxy) {
-            EnvHttpProxyFactory* proxyFactory = new EnvHttpProxyFactory();
+            OwnPtr<EnvHttpProxyFactory> proxyFactory = adoptPtr(new EnvHttpProxyFactory());
             if (proxyFactory->initializeFromEnvironment()) {
-                QNetworkProxyFactory::setApplicationProxyFactory(proxyFactory);
+                QNetworkProxyFactory::setApplicationProxyFactory(proxyFactory.leakPtr());
                 return;
             }