Changeset 157004 in webkit

Timestamp:

Oct 6, 2013, 12:48:07 PM (13 years ago)

Author:

weinig@apple.com

Message:

Be a bit shouty about final classes while we look into why the bots don't like it.

• dom/Comment.h:
• dom/ProcessingInstruction.h:
• editing/markup.cpp:
• page/PageSerializer.cpp:
• workers/SharedWorker.h:
• workers/Worker.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• dom/Comment.h (modified) (1 diff)
• dom/ProcessingInstruction.h (modified) (1 diff)
• editing/markup.cpp (modified) (1 diff)
• page/PageSerializer.cpp (modified) (1 diff)
• workers/SharedWorker.h (modified) (1 diff)
• workers/Worker.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-10-06  Sam Weinig  <sam@webkit.org>
+
+        Be a bit shouty about final classes while we look into why the bots don't like it.
+
+        * dom/Comment.h:
+        * dom/ProcessingInstruction.h:
+        * editing/markup.cpp:
+        * page/PageSerializer.cpp:
+        * workers/SharedWorker.h:
+        * workers/Worker.h:
+
 2013-10-06  Sam Weinig  <sam@webkit.org>
 

trunk/Source/WebCore/dom/Comment.h

@@ -28 +28 @@
 namespace WebCore {
 
-class Comment final : public CharacterData {
+class Comment FINAL : public CharacterData {
 public:
     static PassRefPtr<Comment> create(Document&, const String&);

trunk/Source/WebCore/dom/ProcessingInstruction.h

@@ -33 +33 @@
 class CSSStyleSheet;
 
-class ProcessingInstruction final : public CharacterData, private CachedStyleSheetClient {
+class ProcessingInstruction FINAL : public CharacterData, private CachedStyleSheetClient {
 public:
     static PassRefPtr<ProcessingInstruction> create(Document&, const String& target, const String& data);

trunk/Source/WebCore/editing/markup.cpp

@@ -118 +118 @@
 }
     
-class StyledMarkupAccumulator final : public MarkupAccumulator {
+class StyledMarkupAccumulator FINAL : public MarkupAccumulator {
 public:
     enum RangeFullySelectsNode { DoesFullySelectNode, DoesNotFullySelectNode };

trunk/Source/WebCore/page/PageSerializer.cpp

@@ -96 +96 @@
 }
 
-class SerializerMarkupAccumulator final : public WebCore::MarkupAccumulator {
+class SerializerMarkupAccumulator FINAL : public WebCore::MarkupAccumulator {
 public:
     SerializerMarkupAccumulator(PageSerializer&, Document&, Vector<Node*>*);

trunk/Source/WebCore/workers/SharedWorker.h

@@ -39 +39 @@
 namespace WebCore {
 
-    class SharedWorker final : public AbstractWorker {
+    class SharedWorker FINAL : public AbstractWorker {
     public:
         static PassRefPtr<SharedWorker> create(ScriptExecutionContext&, const String& url, const String& name, ExceptionCode&);

trunk/Source/WebCore/workers/Worker.h

@@ -50 +50 @@
     typedef int ExceptionCode;
 
-    class Worker final : public AbstractWorker, private WorkerScriptLoaderClient {
+    class Worker FINAL : public AbstractWorker, private WorkerScriptLoaderClient {
     public:
         static PassRefPtr<Worker> create(ScriptExecutionContext&, const String& url, ExceptionCode&);