Changeset 157602 in webkit

Timestamp:

Oct 17, 2013, 2:38:41 PM (13 years ago)

Author:

zhajiang@rim.com

Message:

[BlackBerry] Improve the viewport of some websites like mobilesyrup.com/2013/08/25/moto-x-review/
​https://bugs.webkit.org/show_bug.cgi?id=122995

Patch by Jacky Jiang <​zhajiang@blackberry.com> on 2013-10-17.
Reviewed by George Staikos.
Internally reviewed by George Staikos and Eli Fidler.

JIRA 523949
Force to respect the viewport when there is viewport meta tag but width
is not specified even though the viewport is broken. By doing that, We
want to improve the user experience of some websites that use a reasonable
initial-scale, but have some overly-wide contents

The contents of those websites like mobilesyrup.com/2013/08/25/moto-x-review
should be improved by the contents provider eventually.

• Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):

Location:

trunk/Source/WebKit/blackberry

Files:

• Api/WebPage.cpp (modified) (1 diff)
• ChangeLog (modified) (1 diff)

trunk/Source/WebKit/blackberry/Api/WebPage.cpp

@@ -3386 +3386 @@
         return IntSize();
 
+    // We want to respect viewport when width is not specified in the viewport meta tag in order to improve the
+    // user experience of some websites that use a reasonable initial-scale, but have some overly-wide contents.
+    if (m_viewportArguments.width == ViewportArguments::ValueAuto)
+        m_forceRespectViewportArguments = true;
+
     int desktopWidth = DEFAULT_MAX_LAYOUT_WIDTH;
     int deviceWidth = Platform::Graphics::Screen::primaryScreen()->width();

trunk/Source/WebKit/blackberry/ChangeLog

@@ +1 @@
+2013-10-17  Jacky Jiang  <zhajiang@blackberry.com>
+
+        [BlackBerry] Improve the viewport of some websites like mobilesyrup.com/2013/08/25/moto-x-review/
+        https://bugs.webkit.org/show_bug.cgi?id=122995
+
+        Reviewed by George Staikos.
+        Internally reviewed by George Staikos and Eli Fidler.
+
+        JIRA 523949
+        Force to respect the viewport when there is viewport meta tag but width
+        is not specified even though the viewport is broken. By doing that, We
+        want to improve the user experience of some websites that use a reasonable
+        initial-scale, but have some overly-wide contents
+
+        The contents of those websites like mobilesyrup.com/2013/08/25/moto-x-review
+        should be improved by the contents provider eventually.
+
+        * Api/WebPage.cpp:
+        (BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):
+
 2013-10-16  Jochen Eisinger  <jochen@chromium.org>