Changeset 157615 in webkit

Timestamp:

Oct 17, 2013, 5:52:54 PM (13 years ago)

Author:

ap@apple.com

Message:

Don't add an include for return type of a [Custom] function in generated bindings code
​https://bugs.webkit.org/show_bug.cgi?id=122972

Reviewed by Sam Weinig.

• bindings/scripts/CodeGeneratorJS.pm: (GenerateImplementation): Don't.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/scripts/CodeGeneratorJS.pm (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-10-17  Alexey Proskuryakov  <ap@apple.com>
+
+        Don't add an include for return type of a [Custom] function in generated bindings code
+        https://bugs.webkit.org/show_bug.cgi?id=122972
+
+        Reviewed by Sam Weinig.
+
+        * bindings/scripts/CodeGeneratorJS.pm: (GenerateImplementation): Don't.
+
 2013-10-17  Andreas Kling  <akling@apple.com>
 

trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm

@@ -2331 +2331 @@
     if ($numFunctions > 0) {
         foreach my $function (@{$interface->functions}) {
-            AddIncludesForTypeInImpl($function->signature->type);
-
             my $isCustom = HasCustomMethod($function->signature->extendedAttributes);
             my $isOverloaded = $function->{overloads} && @{$function->{overloads}} > 1;
@@ -2338 +2336 @@
 
             next if $isCustom && $isOverloaded && $function->{overloadIndex} > 1;
+
+            AddIncludesForTypeInImpl($function->signature->type) unless $isCustom;
 
             my $functionName = GetFunctionName($className, $function);