Changeset 160143 in webkit

Timestamp:

Dec 4, 2013, 4:17:54 PM (13 years ago)

Author:

Antoine Quint

Message:

Web Inspector: color picker doesn't work with "blue"
​https://bugs.webkit.org/show_bug.cgi?id=125262

Reviewed by Joseph Pecoraro.

Under certain circumstances rounding issues would have us compare
two equal numbers that differ by 0.00000001 and sometime trip this
if statement and yield a null color. We now add a little fudge to
the test and also return a clear color rather than null to match what
we do in the getters for "tintedColor" and "rawColor".

• UserInterface/ColorWheel.js:

(WebInspector.ColorWheel.prototype._colorAtPointWithBrightness):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/ColorWheel.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2013-12-04  Antoine Quint  <graouts@apple.com>
+
+        Web Inspector: color picker doesn't work with "blue"
+        https://bugs.webkit.org/show_bug.cgi?id=125262
+
+        Reviewed by Joseph Pecoraro.
+
+        Under certain circumstances rounding issues would have us compare
+        two equal numbers that differ by 0.00000001 and sometime trip this
+        if statement and yield a null color. We now add a little fudge to
+        the test and also return a clear color rather than null to match what
+        we do in the getters for "tintedColor" and "rawColor".
+
+        * UserInterface/ColorWheel.js:
+        (WebInspector.ColorWheel.prototype._colorAtPointWithBrightness):
+
 2013-12-04  Antoine Quint  <graouts@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/ColorWheel.js

@@ -232 +232 @@
         var distance = Math.sqrt(xDis * xDis + yDis * yDis);
 
-        if (distance > center)
-            return null;
+        if (distance - center > 0.001)
+            return new WebInspector.Color(WebInspector.Color.Format.RGBA, [0, 0, 0, 0]);
 
         var h = Math.atan2(y - center, center - x) * 180 / Math.PI;