Changeset 160157 in webkit

Timestamp:

Dec 4, 2013, 7:57:12 PM (13 years ago)

Author:

rniwa@webkit.org

Message:

bgColor, setBgColor, alinkColor, setAlinkColor, and etc... on HTMLBodyElement are useless
​https://bugs.webkit.org/show_bug.cgi?id=125208

Rubber-stamped by Anders Carlsson.

Address Darin's comment to use fastGetAttribute instead of getAttribute.

• html/HTMLDocument.cpp:

(WebCore::HTMLDocument::bgColor):
(WebCore::HTMLDocument::fgColor):
(WebCore::HTMLDocument::alinkColor):
(WebCore::HTMLDocument::linkColor):
(WebCore::HTMLDocument::vlinkColor):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/HTMLDocument.cpp (modified) (5 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-12-04  Ryosuke Niwa  <rniwa@webkit.org>
+
+        bgColor, setBgColor, alinkColor, setAlinkColor, and etc... on HTMLBodyElement are useless
+        https://bugs.webkit.org/show_bug.cgi?id=125208
+
+        Rubber-stamped by Anders Carlsson.
+
+        Address Darin's comment to use fastGetAttribute instead of getAttribute.
+
+        * html/HTMLDocument.cpp:
+        (WebCore::HTMLDocument::bgColor):
+        (WebCore::HTMLDocument::fgColor):
+        (WebCore::HTMLDocument::alinkColor):
+        (WebCore::HTMLDocument::linkColor):
+        (WebCore::HTMLDocument::vlinkColor):
+
 2013-12-04  Brian J. Burg  <burg@cs.washington.edu>
 

trunk/Source/WebCore/html/HTMLDocument.cpp

@@ -164 +164 @@
     if (!bodyElement || !isHTMLBodyElement(bodyElement))
         return emptyAtom;
-    return bodyElement->getAttribute(bgcolorAttr);
+    return bodyElement->fastGetAttribute(bgcolorAttr);
 }
 
@@ -180 +180 @@
     if (!bodyElement || !isHTMLBodyElement(bodyElement))
         return emptyAtom;
-    return bodyElement->getAttribute(textAttr);
+    return bodyElement->fastGetAttribute(textAttr);
 }
 
@@ -196 +196 @@
     if (!bodyElement || !isHTMLBodyElement(bodyElement))
         return emptyAtom;
-    return bodyElement->getAttribute(alinkAttr);
+    return bodyElement->fastGetAttribute(alinkAttr);
 }
 
@@ -212 +212 @@
     if (!bodyElement || !isHTMLBodyElement(bodyElement))
         return emptyAtom;
-    return bodyElement->getAttribute(linkAttr);
+    return bodyElement->fastGetAttribute(linkAttr);
 }
 
@@ -228 +228 @@
     if (!bodyElement || !isHTMLBodyElement(bodyElement))
         return emptyAtom;
-    return bodyElement->getAttribute(vlinkAttr);
+    return bodyElement->fastGetAttribute(vlinkAttr);
 }