Changeset 166236 in webkit


Ignore:
Timestamp:
Mar 25, 2014 9:42:15 AM (10 years ago)
Author:
ddkilzer@apple.com
Message:

Hold a reference to firstSuccessfulSubmitButton in HTMLFormElement::submit
<​http://webkit.org/b/130713>
<rdar://problem/15661876>

Reviewed by Darin Adler.

Merged from Blink (patch by Ian Beer):
​http://crbug.com/303657
​https://src.chromium.org/viewvc/blink?view=rev&revision=158938

Source/WebCore:

Test: fast/forms/form-submission-crash-successful-submit-button.html

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::submit):

LayoutTests:

  • fast/forms/form-submission-crash-successful-submit-button-expected.txt: Added.
  • fast/forms/form-submission-crash-successful-submit-button.html: Added.
Location:
trunk
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r166231 r166236  
     12014-03-25  David Kilzer  <ddkilzer@apple.com>
     2
     3        Hold a reference to firstSuccessfulSubmitButton in HTMLFormElement::submit
     4        <http://webkit.org/b/130713>
     5        <rdar://problem/15661876>
     6
     7        Reviewed by Darin Adler.
     8
     9        Merged from Blink (patch by Ian Beer):
     10        http://crbug.com/303657
     11        https://src.chromium.org/viewvc/blink?view=rev&revision=158938
     12
     13        * fast/forms/form-submission-crash-successful-submit-button-expected.txt: Added.
     14        * fast/forms/form-submission-crash-successful-submit-button.html: Added.
     15
    1162014-03-20  Sergio Villar Senin  <svillar@igalia.com>
    217

  • trunk/Source/WebCore/ChangeLog

    r166233 r166236  
     12014-03-25  David Kilzer  <ddkilzer@apple.com>
     2
     3        Hold a reference to firstSuccessfulSubmitButton in HTMLFormElement::submit
     4        <http://webkit.org/b/130713>
     5        <rdar://problem/15661876>
     6
     7        Reviewed by Darin Adler.
     8
     9        Merged from Blink (patch by Ian Beer):
     10        http://crbug.com/303657
     11        https://src.chromium.org/viewvc/blink?view=rev&revision=158938
     12
     13        Test: fast/forms/form-submission-crash-successful-submit-button.html
     14
     15        * html/HTMLFormElement.cpp:
     16        (WebCore::HTMLFormElement::submit):
     17
    1182014-03-25  Gabor Rapcsanyi  <rgabor@webkit.org>
    219

  • trunk/Source/WebCore/html/HTMLFormElement.cpp

    r163568 r166236  
    334334    m_wasUserSubmitted = processingUserGesture;
    335335
    336     HTMLFormControlElement* firstSuccessfulSubmitButton = 0;
     336    RefPtr<HTMLFormControlElement> firstSuccessfulSubmitButton;
    337337    bool needButtonActivation = activateSubmitButton; // do we need to activate a submit button?
    338338
Note: See TracChangeset for help on using the changeset viewer.