Changeset 166907 in webkit
- Timestamp:
- Apr 7, 2014 8:49:37 PM (10 years ago)
- Location:
- trunk/Source/WebKit2
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebKit2/ChangeLog
r166906 r166907 1 2014-04-07 Stephanie Lewis <slewis@apple.com> 2 3 Crash in com.apple.WebKit.Plugin.Development at com.apple.WebKit2: WebKit::PluginControllerProxy::pluginInstanceID 4 <rdar://problem/16479432> 5 https://bugs.webkit.org/show_bug.cgi?id=131203 6 7 Reviewed by Geoff Garen. 8 9 pluginController was being removed before accessing the pluginInstanceID. 10 11 * PluginProcess/WebProcessConnection.cpp: 12 (WebKit::WebProcessConnection::removePluginControllerProxy): 13 1 14 2014-04-07 Dan Bernstein <mitz@apple.com> 2 15 -
trunk/Source/WebKit2/PluginProcess/WebProcessConnection.cpp
r166444 r166907 86 86 void WebProcessConnection::removePluginControllerProxy(PluginControllerProxy* pluginController, Plugin* plugin) 87 87 { 88 unsigned pluginInstanceID = pluginController->pluginInstanceID(); 88 89 { 89 ASSERT(m_pluginControllers.contains(plugin Controller->pluginInstanceID()));90 91 std::unique_ptr<PluginControllerProxy> pluginControllerUniquePtr = m_pluginControllers.take(plugin Controller->pluginInstanceID());90 ASSERT(m_pluginControllers.contains(pluginInstanceID)); 91 92 std::unique_ptr<PluginControllerProxy> pluginControllerUniquePtr = m_pluginControllers.take(pluginInstanceID); 92 93 ASSERT(pluginControllerUniquePtr.get() == pluginController); 93 94 } 94 95 95 pluginDidBecomeHidden(plugin Controller->pluginInstanceID());96 pluginDidBecomeHidden(pluginInstanceID); 96 97 97 98 // Invalidate all objects related to this plug-in.
Note: See TracChangeset
for help on using the changeset viewer.