Changeset 167550 in webkit

Timestamp:

Apr 19, 2014, 3:09:51 PM (12 years ago)

Author:

akling@apple.com

Message:

Two little shortcuts to the JSType.
<​https://webkit.org/b/131896>

Tweak two sites that take the long road through JSCell::structure()->typeInfo()
to look at data that's already in JSCell::type().

Reviewed by Darin Adler.

• runtime/NameInstance.h:

(JSC::isName):

• runtime/NumberPrototype.cpp:

(JSC::toThisNumber):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• runtime/NameInstance.h (modified) (1 diff)
• runtime/NumberPrototype.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2014-04-19  Andreas Kling  <akling@apple.com>
+
+        Two little shortcuts to the JSType.
+        <https://webkit.org/b/131896>
+
+        Tweak two sites that take the long road through JSCell::structure()->typeInfo()
+        to look at data that's already in JSCell::type().
+
+        Reviewed by Darin Adler.
+
+        * runtime/NameInstance.h:
+        (JSC::isName):
+        * runtime/NumberPrototype.cpp:
+        (JSC::toThisNumber):
+
 2014-04-19  Filip Pizlo  <fpizlo@apple.com>
 

trunk/Source/JavaScriptCore/runtime/NameInstance.h

@@ -70 +70 @@
 inline bool isName(JSValue v)
 {
-    return v.isCell() && v.asCell()->structure()->typeInfo().isName();
+    return v.isCell() && v.asCell()->type() == NameInstanceType;
 }
 

trunk/Source/JavaScriptCore/runtime/NumberPrototype.cpp

@@ -105 +105 @@
     }
     
-    if (thisValue.isCell() && thisValue.asCell()->structure()->typeInfo().isNumberObject()) {
+    if (thisValue.isCell() && thisValue.asCell()->type() == NumberObjectType) {
         x = static_cast<const NumberObject*>(thisValue.asCell())->internalValue().asNumber();
         return true;