Changeset 167558 in webkit

Timestamp:

Apr 19, 2014, 6:25:28 PM (12 years ago)

Author:

Chris Fleizach

Message:

AX: Malformed tables exposing incorrect col and colSpans
​https://bugs.webkit.org/show_bug.cgi?id=131796

Reviewed by Darin Adler.

Source/WebCore:
Test: accessibility/table-incorrect-colspan-cell.html

When a developer has specified malformed colspans, accessibility is reporting those values instead of the effective column information.

• accessibility/AccessibilityTableCell.cpp:

(WebCore::AccessibilityTableCell::columnIndexRange):

LayoutTests:

• accessibility/table-incorrect-colspan-cell-expected.txt: Added.
• accessibility/table-incorrect-colspan-cell.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/accessibility/table-incorrect-colspan-cell-expected.txt (added)
• LayoutTests/accessibility/table-incorrect-colspan-cell.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/accessibility/AccessibilityTableCell.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2014-04-19  Chris Fleizach  <cfleizach@apple.com>
+
+        AX: Malformed tables exposing incorrect col and colSpans
+        https://bugs.webkit.org/show_bug.cgi?id=131796
+
+        Reviewed by Darin Adler.
+
+        * accessibility/table-incorrect-colspan-cell-expected.txt: Added.
+        * accessibility/table-incorrect-colspan-cell.html: Added.
+
 2014-04-19  Zalan Bujtas  <zalan@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-04-19  Chris Fleizach  <cfleizach@apple.com>
+
+        AX: Malformed tables exposing incorrect col and colSpans
+        https://bugs.webkit.org/show_bug.cgi?id=131796
+
+        Reviewed by Darin Adler.
+
+        Test: accessibility/table-incorrect-colspan-cell.html
+
+        When a developer has specified malformed colspans, accessibility is reporting those values instead of the effective column information.
+
+        * accessibility/AccessibilityTableCell.cpp:
+        (WebCore::AccessibilityTableCell::columnIndexRange):
+
 2014-04-19  Benjamin Poulain  <bpoulain@apple.com>
 

trunk/Source/WebCore/accessibility/AccessibilityTableCell.cpp

@@ -249 +249 @@
         return;
     
-    RenderTableCell* renderCell = toRenderTableCell(m_renderer);
-    columnRange.first = renderCell->col();
-    columnRange.second = renderCell->colSpan();    
+    const RenderTableCell& cell = *toRenderTableCell(m_renderer);
+    columnRange.first = cell.table()->colToEffCol(cell.col());
+    columnRange.second = cell.table()->colToEffCol(cell.col() + cell.colSpan()) - columnRange.first;
 }