Changeset 167559 in webkit

Timestamp:

Apr 19, 2014, 6:38:48 PM (12 years ago)

Author:

Chris Fleizach

Message:

AX: grid rows are not recognized do to lack of explicit role="row", role="gridcell"
​https://bugs.webkit.org/show_bug.cgi?id=131819

Reviewed by Darin Adler.

Source/WebCore:
Test: accessibility/table-with-missing-aria-role-rows.html

If a table is using role="grid", and it has <tr> elements that do not have
role="row", we should still treat them as row elements.

• accessibility/AccessibilityARIAGrid.cpp:

(WebCore::AccessibilityARIAGrid::addTableCellChild):

LayoutTests:

• accessibility/table-with-missing-aria-role-rows-expected.txt: Added.
• accessibility/table-with-missing-aria-role-rows.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/accessibility/table-with-missing-aria-role-rows-expected.txt (added)
• LayoutTests/accessibility/table-with-missing-aria-role-rows.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/accessibility/AccessibilityARIAGrid.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2014-04-19  Chris Fleizach  <cfleizach@apple.com>
+
+        AX: grid rows are not recognized do to lack of explicit role="row", role="gridcell"
+        https://bugs.webkit.org/show_bug.cgi?id=131819
+
+        Reviewed by Darin Adler.
+
+        * accessibility/table-with-missing-aria-role-rows-expected.txt: Added.
+        * accessibility/table-with-missing-aria-role-rows.html: Added.
+
 2014-04-19  Chris Fleizach  <cfleizach@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-04-19  Chris Fleizach  <cfleizach@apple.com>
+
+        AX: grid rows are not recognized do to lack of explicit role="row", role="gridcell"
+        https://bugs.webkit.org/show_bug.cgi?id=131819
+
+        Reviewed by Darin Adler.
+
+        Test: accessibility/table-with-missing-aria-role-rows.html
+
+        If a table is using role="grid", and it has <tr> elements that do not have
+        role="row", we should still treat them as row elements.
+
+        * accessibility/AccessibilityARIAGrid.cpp:
+        (WebCore::AccessibilityARIAGrid::addTableCellChild):
+
 2014-04-19  Chris Fleizach  <cfleizach@apple.com>
 

trunk/Source/WebCore/accessibility/AccessibilityARIAGrid.cpp

@@ -55 +55 @@
 bool AccessibilityARIAGrid::addTableCellChild(AccessibilityObject* child, HashSet<AccessibilityObject*>& appendedRows, unsigned& columnCount)
 {
-    if (!child || !child->isTableRow() || child->ariaRoleAttribute() != RowRole)
+    if (!child || (!child->isTableRow() && child->ariaRoleAttribute() != RowRole))
         return false;