Changeset 167590 in webkit

Timestamp:

Apr 21, 2014, 3:39:51 AM (12 years ago)

Author:

zandobersek@gmail.com

Message:

iOS and non-iOS RemoteCommandListener::create() functions should use std::make_unique<>()
​https://bugs.webkit.org/show_bug.cgi?id=131916

Reviewed by Darin Adler.

A follow-up to r167197. Make RemoteCommandListener ctor public and use std::make_unique<>()
in both versions of RemoteCommandListener::create() functions (iOS and non-iOS).

• platform/RemoteCommandListener.cpp:

(WebCore::RemoteCommandListener::create):

• platform/RemoteCommandListener.h:

(WebCore::RemoteCommandListener::RemoteCommandListener):

• platform/ios/RemoteCommandListenerIOS.mm:

(WebCore::RemoteCommandListener::create):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/RemoteCommandListener.cpp (modified) (1 diff)
• platform/RemoteCommandListener.h (modified) (1 diff)
• platform/ios/RemoteCommandListenerIOS.mm (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-04-21  Zan Dobersek  <zdobersek@igalia.com>
+
+        iOS and non-iOS RemoteCommandListener::create() functions should use std::make_unique<>()
+        https://bugs.webkit.org/show_bug.cgi?id=131916
+
+        Reviewed by Darin Adler.
+
+        A follow-up to r167197. Make RemoteCommandListener ctor public and use std::make_unique<>()
+        in both versions of RemoteCommandListener::create() functions (iOS and non-iOS).
+
+        * platform/RemoteCommandListener.cpp:
+        (WebCore::RemoteCommandListener::create):
+        * platform/RemoteCommandListener.h:
+        (WebCore::RemoteCommandListener::RemoteCommandListener):
+        * platform/ios/RemoteCommandListenerIOS.mm:
+        (WebCore::RemoteCommandListener::create):
+
 2014-04-21  Andreas Kling  <akling@apple.com>
 

trunk/Source/WebCore/platform/RemoteCommandListener.cpp

@@ -32 +32 @@
 std::unique_ptr<RemoteCommandListener> RemoteCommandListener::create(RemoteCommandListenerClient& client)
 {
-    return std::unique_ptr<RemoteCommandListener>(new RemoteCommandListener(client));
+    return std::make_unique<RemoteCommandListener>(client);
 }
 #endif

trunk/Source/WebCore/platform/RemoteCommandListener.h

@@ -40 +40 @@
 public:
     static std::unique_ptr<RemoteCommandListener> create(RemoteCommandListenerClient&);
+    RemoteCommandListener(RemoteCommandListenerClient& client) : m_client(client) { }
     virtual ~RemoteCommandListener() { }
 
 protected:
-    RemoteCommandListener(RemoteCommandListenerClient& client) : m_client(client) { };
-
     RemoteCommandListenerClient& m_client;
 };

trunk/Source/WebCore/platform/ios/RemoteCommandListenerIOS.mm

@@ -42 +42 @@
 std::unique_ptr<RemoteCommandListener> RemoteCommandListener::create(RemoteCommandListenerClient& client)
 {
-    return std::unique_ptr<RemoteCommandListener>(new RemoteCommandListenerIOS(client));
+    return std::make_unique<RemoteCommandListenerIOS>(client);
 }