Changeset 169081 in webkit

Timestamp:

May 19, 2014, 4:37:56 PM (12 years ago)

Author:

Chris Fleizach

Message:

AX: VoiceOver sees the WebArea out of order when topContentInset is used
​https://bugs.webkit.org/show_bug.cgi?id=133091

Reviewed by Simon Fraser.

Source/WebCore:
Modify the scroll view's frame so that it recognizes the content inset.
This is needed so that when VoiceOver sorts elements to create an ordering,
the web area is not ordered at the top of the screen.

Test: platform/mac-wk2/accessibility/content-inset-scrollview-frame.html

• accessibility/AccessibilityScrollView.cpp:

(WebCore::AccessibilityScrollView::elementRect):

LayoutTests:

• platform/mac-wk2/accessibility/content-inset-scrollview-frame-expected.txt: Added.
• platform/mac-wk2/accessibility/content-inset-scrollview-frame.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/mac-wk2/accessibility/content-inset-scrollview-frame-expected.txt (added)
• LayoutTests/platform/mac-wk2/accessibility/content-inset-scrollview-frame.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/accessibility/AccessibilityScrollView.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2014-05-19  Chris Fleizach  <cfleizach@apple.com>
+
+        AX: VoiceOver sees the WebArea out of order when topContentInset is used
+        https://bugs.webkit.org/show_bug.cgi?id=133091
+
+        Reviewed by Simon Fraser.
+
+        * platform/mac-wk2/accessibility/content-inset-scrollview-frame-expected.txt: Added.
+        * platform/mac-wk2/accessibility/content-inset-scrollview-frame.html: Added.
+
 2014-05-19  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-05-19  Chris Fleizach  <cfleizach@apple.com>
+
+        AX: VoiceOver sees the WebArea out of order when topContentInset is used
+        https://bugs.webkit.org/show_bug.cgi?id=133091
+
+        Reviewed by Simon Fraser.
+
+        Modify the scroll view's frame so that it recognizes the content inset.
+        This is needed so that when VoiceOver sorts elements to create an ordering,
+        the web area is not ordered at the top of the screen.
+
+        Test: platform/mac-wk2/accessibility/content-inset-scrollview-frame.html
+
+        * accessibility/AccessibilityScrollView.cpp:
+        (WebCore::AccessibilityScrollView::elementRect):
+
 2014-05-19  Beth Dakin  <bdakin@apple.com>
 

trunk/Source/WebCore/accessibility/AccessibilityScrollView.cpp

@@ -222 +222 @@
         return LayoutRect();
 
-    return m_scrollView->frameRect();
+    LayoutRect rect = m_scrollView->frameRect();
+    rect.setY(rect.y() + m_scrollView->topContentInset());
+    return rect;
 }