Changeset 169091 in webkit

Timestamp:

May 19, 2014, 6:09:37 PM (12 years ago)

Author:

enrica@apple.com

Message:

WK2 iOS: Pressing the form navigation button causes the keyboard to be dismissed.
​https://bugs.webkit.org/show_bug.cgi?id=133100
<rdar://problem/16808673>

Reviewed by Benjamin Poulain.

The call to focusNextAssistedNode is the result of a user action, since
it is called when the user pressed the form navigation buttons.
Therefore we must set m_userIsInteracting to true before changing the focus
to make sure the focus change is honored.

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::focusNextAssistedNode):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/WebPage/ios/WebPageIOS.mm (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2014-05-19  Enrica Casucci  <enrica@apple.com>
+
+        WK2 iOS: Pressing the form navigation button causes the keyboard to be dismissed.
+        https://bugs.webkit.org/show_bug.cgi?id=133100
+        <rdar://problem/16808673>
+
+        Reviewed by Benjamin Poulain.
+
+        The call to focusNextAssistedNode is the result of a user action, since
+        it is called when the user pressed the form navigation buttons.
+        Therefore we must set m_userIsInteracting to true before changing the focus
+        to make sure the focus change is honored.
+
+        * WebProcess/WebPage/ios/WebPageIOS.mm:
+        (WebKit::WebPage::focusNextAssistedNode):
+
 2014-05-19  Beth Dakin  <bdakin@apple.com>
 

trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm

@@ -1774 +1774 @@
 {
     Element* nextElement = nextFocusableElement(m_assistedNode.get(), m_page.get(), isForward);
+    m_userIsInteracting = true;
     if (nextElement)
         nextElement->focus();
+    m_userIsInteracting = false;
 }