Changeset 169093 in webkit

Timestamp:

May 19, 2014, 6:56:41 PM (12 years ago)

Author:

Chris Fleizach

Message:

AX: VoiceOver sees the WebArea out of order when topContentInset is used
​https://bugs.webkit.org/show_bug.cgi?id=133091

Unreviewed.
Make the layout test more resilient to platform differences in frame positions.

• platform/mac-wk2/accessibility/content-inset-scrollview-frame-expected.txt:
• platform/mac-wk2/accessibility/content-inset-scrollview-frame.html:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• platform/mac-wk2/accessibility/content-inset-scrollview-frame-expected.txt (modified) (1 diff)
• platform/mac-wk2/accessibility/content-inset-scrollview-frame.html (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2014-05-19  Chris Fleizach  <cfleizach@apple.com>
+
+        AX: VoiceOver sees the WebArea out of order when topContentInset is used
+        https://bugs.webkit.org/show_bug.cgi?id=133091
+
+        Unreviewed. 
+        Make the layout test more resilient to platform differences in frame positions.
+
+        * platform/mac-wk2/accessibility/content-inset-scrollview-frame-expected.txt:
+        * platform/mac-wk2/accessibility/content-inset-scrollview-frame.html:
+
 2014-05-19  Myles C. Maxfield  <litherum@gmail.com>
 

trunk/LayoutTests/platform/mac-wk2/accessibility/content-inset-scrollview-frame-expected.txt

@@ -4 +4 @@
 
 
-Web area role: AXRole: AXWebArea
-WebArea frame: {-10000, 10300}, {800, 600}
-ScrollView role: AXRole: AXScrollArea
-ScrollView frame (0 content inset): {-10000, 10300}, {800, 600}
-ScrollView frame (100 content inset): {-10000, 10200}, {800, 600}
+The position of the web area and the scroll view should be the same when there's no content inset
+PASS webX == scrollViewX && webY == scrollViewY is true
+After setting the content inset, the new y position should be less than the initial
+PASS scrollViewY - scrollView.y is 100
 PASS successfullyParsed is true
 

trunk/LayoutTests/platform/mac-wk2/accessibility/content-inset-scrollview-frame.html

@@ -13 +13 @@
     description("This tests that a page with a content inset will not affect the bounds of the main frame scroll view. It will appear as the same as the web area's sbounds");
 
-    function outputFrame(message, element) {
-        debug(message + ": {" + element.x + ", " + element.y + "}, {" + element.width + ", " + element.height + "}");
-    }
-
     if (window.accessibilityController) {
         var webArea = accessibilityController.rootElement.childAtIndex(0);
-        debug("Web area role: " + webArea.role);
-        outputFrame("WebArea frame", webArea);
+        var webX = webArea.x;
+        var webY = webArea.y;
 
         var scrollView = webArea.parentElement();
-        debug("ScrollView role: " + scrollView.role);
-        outputFrame("ScrollView frame (0 content inset)", scrollView);
-    
+        var scrollViewX = scrollView.x;
+        var scrollViewY = scrollView.y;
+  
+        debug("The position of the web area and the scroll view should be the same when there's no content inset");
+        shouldBeTrue("webX == scrollViewX && webY == scrollViewY");
+ 
         window.internals.setTopContentInset(100);
 
-        outputFrame("ScrollView frame (100 content inset)", scrollView);
+        debug("After setting the content inset, the new y position should be less than the initial");
+        shouldBe("scrollViewY - scrollView.y", "100")
     }
 </script>