Changeset 169921 in webkit

Timestamp:

Jun 12, 2014, 4:49:02 PM (12 years ago)

Author:

jer.noble@apple.com

Message:

[MSE][Mac] Stop observing the sample buffer renderers when destroying them.
​https://bugs.webkit.org/show_bug.cgi?id=133831

Reviewed by Beth Dakin.

Release our retain on our AVSampleBufferDisplayLayer and AVSampleBufferAudioRenderer by stopping
our observation of its properties when removing them from the SourceBufferPrivateAVFObjC object.

• platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:

(WebCore::SourceBufferPrivateAVFObjC::destroyRenderers):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-06-12  Jer Noble  <jer.noble@apple.com>
+
+        [MSE][Mac] Stop observing the sample buffer renderers when destroying them.
+        https://bugs.webkit.org/show_bug.cgi?id=133831
+
+        Reviewed by Beth Dakin.
+
+        Release our retain on our AVSampleBufferDisplayLayer and AVSampleBufferAudioRenderer by stopping
+        our observation of its properties when removing them from the SourceBufferPrivateAVFObjC object.
+
+        * platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
+        (WebCore::SourceBufferPrivateAVFObjC::destroyRenderers):
+
 2014-06-12  Brent Fulgham  <bfulgham@apple.com>
 

trunk/Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm

@@ -720 +720 @@
         [m_displayLayer flush];
         [m_displayLayer stopRequestingMediaData];
+        [m_errorListener stopObservingLayer:m_displayLayer.get()];
         m_displayLayer = nullptr;
     }
@@ -729 +730 @@
         [renderer flush];
         [renderer stopRequestingMediaData];
+        [m_errorListener stopObservingLayer:renderer];
     }