Changeset 170665 in webkit

Timestamp:

Jul 1, 2014, 2:12:08 PM (12 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: Selected DOM element highlights invisible near bottom of the viewport (topContentInset?)
​https://bugs.webkit.org/show_bug.cgi?id=133818

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-07-01
Reviewed by Beth Dakin.

• inspector/InspectorOverlay.cpp:

(WebCore::InspectorOverlay::update):
Take the topContentInset into account when sizing the InspectorOverlay's FrameView.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/InspectorOverlay.cpp (modified) (4 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-07-01  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Web Inspector: Selected DOM element highlights invisible near bottom of the viewport (topContentInset?)
+        https://bugs.webkit.org/show_bug.cgi?id=133818
+
+        Reviewed by Beth Dakin.
+
+        * inspector/InspectorOverlay.cpp:
+        (WebCore::InspectorOverlay::update):
+        Take the topContentInset into account when sizing the InspectorOverlay's FrameView.
+
 2014-07-01  Chris Fleizach  <cfleizach@apple.com>
 

trunk/Source/WebCore/inspector/InspectorOverlay.cpp

@@ -64 +64 @@
 namespace WebCore {
 
-namespace {
-
-Path quadToPath(const FloatQuad& quad)
+static Path quadToPath(const FloatQuad& quad)
 {
     Path quadPath;
@@ -77 +75 @@
 }
 
-void drawOutlinedQuad(GraphicsContext* context, const FloatQuad& quad, const Color& fillColor, const Color& outlineColor)
+static void drawOutlinedQuad(GraphicsContext* context, const FloatQuad& quad, const Color& fillColor, const Color& outlineColor)
 {
     static const int outlineThickness = 2;
@@ -238 +236 @@
 }
 
-} // anonymous namespace
-
 InspectorOverlay::InspectorOverlay(Page& page, InspectorClient* client)
     : m_page(page)
@@ -349 +345 @@
 
     FrameView* overlayView = overlayPage()->mainFrame().view();
-    IntSize viewportSize = view->visibleContentRect().size();
-    IntSize frameViewFullSize = view->visibleContentRectIncludingScrollbars().size();
+    IntSize viewportSize = view->unscaledTotalVisibleContentSize();
+    IntSize frameViewFullSize = view->unscaledTotalVisibleContentSize(ScrollableArea::IncludeScrollbars);
     overlayPage()->setPageScaleFactor(m_page.pageScaleFactor(), IntPoint());
     frameViewFullSize.scale(m_page.pageScaleFactor());