Changeset 170678 in webkit

Timestamp:

Jul 1, 2014, 4:57:07 PM (12 years ago)

Author:

Chris Fleizach

Message:

AX: iOS does not expose ARIA toggle buttons at all (not even as a regular button)
​https://bugs.webkit.org/show_bug.cgi?id=133875

Reviewed by Enrica Casucci.

Source/WebCore:
Support the toggle button type in iOS.

Test: platform/ios-sim/accessibility/toggle-button.html

• accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper accessibilityCanFuzzyHitTest]):
(-[WebAccessibilityObjectWrapper accessibilityTraits]):
(-[WebAccessibilityObjectWrapper determineIsAccessibilityElement]):

LayoutTests:

• platform/ios-sim/accessibility/toggle-button-expected.txt: Added.
• platform/ios-sim/accessibility/toggle-button.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/ios-sim/accessibility/toggle-button-expected.txt (added)
• LayoutTests/platform/ios-sim/accessibility/toggle-button.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm (modified) (3 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2014-07-01  Chris Fleizach  <cfleizach@apple.com>
+
+        AX: iOS does not expose ARIA toggle buttons at all (not even as a regular button)
+        https://bugs.webkit.org/show_bug.cgi?id=133875
+
+        Reviewed by Enrica Casucci.
+
+        * platform/ios-sim/accessibility/toggle-button-expected.txt: Added.
+        * platform/ios-sim/accessibility/toggle-button.html: Added.
+
 2014-07-01  Dean Jackson  <dino@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-07-01  Chris Fleizach  <cfleizach@apple.com>
+
+        AX: iOS does not expose ARIA toggle buttons at all (not even as a regular button)
+        https://bugs.webkit.org/show_bug.cgi?id=133875
+
+        Reviewed by Enrica Casucci.
+
+        Support the toggle button type in iOS.
+
+        Test: platform/ios-sim/accessibility/toggle-button.html
+
+        * accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
+        (-[WebAccessibilityObjectWrapper accessibilityCanFuzzyHitTest]):
+        (-[WebAccessibilityObjectWrapper accessibilityTraits]):
+        (-[WebAccessibilityObjectWrapper determineIsAccessibilityElement]):
+
 2014-07-01  Dean Jackson  <dino@apple.com>
 

trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm

@@ -302 +302 @@
     case TabRole:
     case TextFieldRole:
+    case ToggleButtonRole:
         return !m_object->accessibilityIsIgnored();
     default:
@@ -563 +564 @@
             traits |= [self _axRadioButtonTrait] | [self _axToggleTrait];
             break;
+        case ToggleButtonRole:
         case CheckBoxRole:
             traits |= ([self _axButtonTrait] | [self _axToggleTrait]);
@@ -624 +626 @@
         case TextAreaRole:
         case ButtonRole:
+        case ToggleButtonRole:
         case PopUpButtonRole:
         case CheckBoxRole: