Changeset 17128 in webkit

Timestamp:

Oct 18, 2006 10:02:54 PM (18 years ago)

Author:

thatcher

Message:

Reviewed by Anders.

Bug 10851: Crash with Drosera
​http://bugs.webkit.org/show_bug.cgi?id=10851

This crash results in an assert in debug builds.

assert(implementsCall());

The drosera_introspection propery was not callable. Now we just assign
this.drosera_introspection in the evaluateWebScript call.
This change also removes one DO message.

• Drosera/DebuggerDocument.m: (-[WebScriptObject webScriptAttributeKeysForScriptObject:]):

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• Drosera/DebuggerDocument.m (modified) (1 diff)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2006-10-18  Timothy Hatcher  <timothy@apple.com>
+
+        Reviewed by Anders.
+
+        Bug 10851: Crash with Drosera
+        http://bugs.webkit.org/show_bug.cgi?id=10851
+
+        This crash results in an assert in debug builds.
+
+        assert(implementsCall());
+
+        The __drosera_introspection propery was not callable. Now we just assign
+        this.__drosera_introspection in the evaluateWebScript call.
+        This change also removes one DO message.
+
+        * Drosera/DebuggerDocument.m:
+        (-[WebScriptObject webScriptAttributeKeysForScriptObject:]):
+
 2006-10-18  Mark Rowe  <bdash@webkit.org>
 

trunk/WebKitTools/Drosera/DebuggerDocument.m

@@ -113 +113 @@
 - (NSArray *)webScriptAttributeKeysForScriptObject:(WebScriptObject *)object
 {
-    WebScriptObject *func = [object evaluateWebScript:@"(function () { var result = new Array(); for (var x in this) { result.push(x); } return result; })"];
-    [object setValue:func forKey:@"__drosera_introspection"];
+    [object evaluateWebScript:@"this.__drosera_introspection = function () { var result = new Array(); for (var x in this) { result.push(x); } return result; }"];
 
     NSMutableArray *result = [[NSMutableArray alloc] init];