Changeset 173533 in webkit

Timestamp:

Sep 11, 2014, 12:57:33 PM (12 years ago)

Author:

jer.noble@apple.com

Message:

Add site-specific quirk for entering fullscreen on YouTube.com.
​https://bugs.webkit.org/show_bug.cgi?id=136742

Reviewed by Eric Carlson.

YouTube only resizes its <video> content when entering fullscreen after receiving the "webkitfullscreenchange"
event, which is fired once the animation to enter fullscreen completes. This leaves the apparent <video> content
too small during the animation, especially at the beginning of the animation. Add a site-specific hack for
YouTube sites which fires the "webkitfullscreenchange" event synchronously with the beginning of the enter
fullscreen animation. This will cause YouTube to resize their <video> content during the period of time where we
disable screen updates, and makes the enter fullscreen animation seamless.

Add a static utility method, hostIsYouTube(), for the various pieces of this site-specific hack, and expand it
to match youtube.co.uk, youtube.fr, etc.

• dom/Document.cpp:

(WebCore::hostIsYouTube): Added.
(WebCore::Document::webkitWillEnterFullScreenForElement): Fire fullscreenchange event if hacks are enabled.
(WebCore::Document::webkitDidEnterFullScreenForElement): Don't fire the event if same.
(WebCore::Document::webkitDidExitFullScreenForElement): Use hostIsYouTube().

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• dom/Document.cpp (modified) (5 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-09-11  Jer Noble  <jer.noble@apple.com>
+
+        Add site-specific quirk for entering fullscreen on YouTube.com.
+        https://bugs.webkit.org/show_bug.cgi?id=136742
+
+        Reviewed by Eric Carlson.
+
+        YouTube only resizes its <video> content when entering fullscreen after receiving the "webkitfullscreenchange"
+        event, which is fired once the animation to enter fullscreen completes. This leaves the apparent <video> content
+        too small during the animation, especially at the beginning of the animation. Add a site-specific hack for
+        YouTube sites which fires the "webkitfullscreenchange" event synchronously with the beginning of the enter
+        fullscreen animation. This will cause YouTube to resize their <video> content during the period of time where we
+        disable screen updates, and makes the enter fullscreen animation seamless.
+
+        Add a static utility method, hostIsYouTube(), for the various pieces of this site-specific hack, and expand it
+        to match youtube.co.uk, youtube.fr, etc.
+
+        * dom/Document.cpp:
+        (WebCore::hostIsYouTube): Added.
+        (WebCore::Document::webkitWillEnterFullScreenForElement): Fire fullscreenchange event if hacks are enabled.
+        (WebCore::Document::webkitDidEnterFullScreenForElement): Don't fire the event if same.
+        (WebCore::Document::webkitDidExitFullScreenForElement): Use hostIsYouTube().
+        
 2014-09-11  Bear Travis  <betravis@adobe.com>
 

trunk/Source/WebCore/dom/Document.cpp

@@ -159 +159 @@
 #include <wtf/TemporaryChange.h>
 #include <wtf/text/StringBuffer.h>
+#include <yarr/RegularExpression.h>
 
 #if ENABLE(SHARED_WORKERS)
@@ -5332 +5333 @@
 }
 
+static bool hostIsYouTube(const String& host)
+{
+    // Match .youtube.com, youtube.com, youtube.co.uk, and all two-letter country codes.
+    static NeverDestroyed<JSC::Yarr::RegularExpression> youtubePattern("(^|\\.)youtube.(com|co.uk|[a-z]{2})$", TextCaseInsensitive);
+    ASSERT(youtubePattern.get().isValid());
+
+    return youtubePattern.get().match(host);
+}
+
 void Document::webkitWillEnterFullScreenForElement(Element* element)
 {
@@ -5369 +5379 @@
 
     m_fullScreenElement->setContainsFullScreenElementOnAncestorsCrossingFrameBoundaries(true);
-    
+
+    if (settings() && settings()->needsSiteSpecificQuirks() && hostIsYouTube(url().host()))
+        fullScreenChangeDelayTimerFired(m_fullScreenChangeDelayTimer);
+
     recalcStyle(Style::Force);
 }
@@ -5383 +5396 @@
     m_fullScreenElement->didBecomeFullscreenElement();
 
-    m_fullScreenChangeDelayTimer.startOneShot(0);
+    if (!settings() || !settings()->needsSiteSpecificQuirks() || !hostIsYouTube(url().host()))
+        m_fullScreenChangeDelayTimer.startOneShot(0);
 }
 
@@ -5422 +5436 @@
     // FIXME(136605): Remove this quirk once YouTube moves to relative widths and heights for
     // fullscreen mode.
-    String host = url().host();
-    if (settings() && settings()->needsSiteSpecificQuirks() && (host.endsWith(".youtube.com", false) || equalIgnoringCase("youtube.com", host)))
+    if (settings() && settings()->needsSiteSpecificQuirks() && hostIsYouTube(url().host()))
         exitingDocument.fullScreenChangeDelayTimerFired(exitingDocument.m_fullScreenChangeDelayTimer);
     else