Changeset 173547 in webkit

Timestamp:

Sep 11, 2014, 4:12:53 PM (12 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: Fix assert in QuickConsole - main frame execution context path component
​https://bugs.webkit.org/show_bug.cgi?id=136748

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-09-11
Reviewed by Timothy Hatcher.

This can get called for the MainFrame on page navigations.
In such cases we can return a better result from this method.

• UserInterface/Views/QuickConsole.js:

(WebInspector.QuickConsole.prototype._insertExecutionContextPathComponentForFrame):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/QuickConsole.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2014-09-11  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Web Inspector: Fix assert in QuickConsole - main frame execution context path component
+        https://bugs.webkit.org/show_bug.cgi?id=136748
+
+        Reviewed by Timothy Hatcher.
+
+        This can get called for the MainFrame on page navigations.
+        In such cases we can return a better result from this method.
+
+        * UserInterface/Views/QuickConsole.js:
+        (WebInspector.QuickConsole.prototype._insertExecutionContextPathComponentForFrame):
+
 2014-09-11  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/QuickConsole.js

@@ -247 +247 @@
     _insertExecutionContextPathComponentForFrame: function(frame, skipRebuild)
     {
-        console.assert(!frame.isMainFrame());
         if (frame.isMainFrame())
-            return null;
+            return this._mainFrameExecutionContextPathComponent;
 
         console.assert(!this._frameIdentifierToExecutionContextPathComponentMap[frame.id]);