Changeset 173556 in webkit

Timestamp:

Sep 11, 2014, 10:32:33 PM (12 years ago)

Author:

ap@apple.com

Message:

fast/forms/submit-to-blank-multiple-times.html crashes with JSC_slowPathAllocsBetweenGCs
​https://bugs.webkit.org/show_bug.cgi?id=136716

Reviewed by Darin Adler.

This test used a fake timeout handler, which is not needed, because WRT/WKTR do it for you.
Any time the test took over 2 seconds, we would dump and disable waiting for notifyDone,
but the test would still try to open windows after that.

• fast/forms/submit-to-blank-multiple-times.html:
• platform/mac/TestExpectations:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• fast/forms/submit-to-blank-multiple-times.html (modified) (3 diffs)
• platform/mac/TestExpectations (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2014-09-11  Alexey Proskuryakov  <ap@apple.com>
+
+        fast/forms/submit-to-blank-multiple-times.html crashes with JSC_slowPathAllocsBetweenGCs
+        https://bugs.webkit.org/show_bug.cgi?id=136716
+
+        Reviewed by Darin Adler.
+
+        This test used a fake timeout handler, which is not needed, because WRT/WKTR do it for you.
+        Any time the test took over 2 seconds, we would dump and disable waiting for notifyDone,
+        but the test would still try to open windows after that.
+
+        * fast/forms/submit-to-blank-multiple-times.html:
+        * platform/mac/TestExpectations:
+
 2014-09-11  Shivakumar JM  <shiva.jm@samsung.com>
 

trunk/LayoutTests/fast/forms/submit-to-blank-multiple-times.html

@@ -21 +21 @@
             testRunner.dumpAsText();
             testRunner.setCanOpenWindows();
+            testRunner.setCloseRemainingWindowsWhenComplete();
             testRunner.waitUntilDone();
         }
@@ -30 +31 @@
             
             click();
-            // Set a timeout to notify done in case the test fails.
-            setTimeout(notifyDone, 2000);
         };
         function log(message) {
@@ -66 +65 @@
         }
         function notifyDone() {
-            testRunner.setCloseRemainingWindowsWhenComplete();
             testRunner.notifyDone();
         }

trunk/LayoutTests/platform/mac/TestExpectations

@@ -1155 +1155 @@
 webkit.org/b/135133 [ MountainLion ] fast/layers/no-clipping-overflow-hidden-added-after-transform.html [ Pass ImageOnlyFailure ]
 
-webkit.org/b/136716 fast/forms/submit-to-blank-multiple-times.html [ Skip ]
-
 webkit.org/b/136717 js/dom/string-replace-exception-crash.html [ Skip ]