Changeset 175197 in webkit

Timestamp:

Oct 24, 2014, 7:37:41 PM (12 years ago)

Author:

Alan Bujtas

Message:

Clamp wordSpacing percentage value.
​https://bugs.webkit.org/show_bug.cgi?id=129350.

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2014-10-24
Reviewed by Zalan Bujtas.

Source/WebCore:

When the CSS wordSpacing property is percentage, its value has to be within the
pre-defined min/max values for the CSS length type. This is done the same way
the wordSpacing of type <length> is handled.

Tests: css3/infinite-word-spacing.html.

Move the definitions of minValueForCssLength and maxValueForCssLength from the
.cpp file to the .h file.

• css/CSSPrimitiveValue.cpp:
• css/CSSPrimitiveValue.h:

Clamp the wordSpacing value to minValueForCssLength and maxValueForCssLength when
its type is percentage.

• css/DeprecatedStyleBuilder.cpp:

(WebCore::ApplyPropertyWordSpacing::applyValue):

LayoutTests:

Make sure that setting the CSS style wordSpacing property to very huge percentage
value and blending this value with other values for animating key frames does
not assert or crash. The expectation is to have this huge value to be clamped to
the pre-defined min/max values for the CSS length type. So when blending the clamped
value with other wordSpacing values, the result can't be NaN. This should be very
similar to the case when it is set to a huge <length> value.

• css3/infinite-word-spacing-expected.txt: Added.
• css3/infinite-word-spacing.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/css3/infinite-word-spacing-expected.txt (added)
• LayoutTests/css3/infinite-word-spacing.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/css/CSSPrimitiveValue.cpp (modified) (2 diffs)
• Source/WebCore/css/CSSPrimitiveValue.h (modified) (2 diffs)
• Source/WebCore/css/DeprecatedStyleBuilder.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2014-10-24  Said Abou-Hallawa  <sabouhallawa@apple.com>
+
+        Clamp wordSpacing percentage value.
+        https://bugs.webkit.org/show_bug.cgi?id=129350.
+
+        Reviewed by Zalan Bujtas.
+
+        Make sure that setting the CSS style wordSpacing property to very huge percentage
+        value and blending this value with other values for animating key frames does
+        not assert or crash. The expectation is to have this huge value to be clamped to
+        the pre-defined min/max values for the CSS length type. So when blending the clamped
+        value with other wordSpacing values, the result can't be NaN. This should be very
+        similar to the case when it is set to a huge <length> value.
+
+        * css3/infinite-word-spacing-expected.txt: Added.
+        * css3/infinite-word-spacing.html: Added.
+
 2014-10-24  Alexey Proskuryakov  <ap@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-10-24  Said Abou-Hallawa  <sabouhallawa@apple.com>
+
+        Clamp wordSpacing percentage value.
+        https://bugs.webkit.org/show_bug.cgi?id=129350.
+
+        Reviewed by Zalan Bujtas.
+
+        When the CSS wordSpacing property is percentage, its value has to be within the
+        pre-defined min/max values for the CSS length type. This is done the same way
+        the wordSpacing of type <length> is handled.
+
+        Tests: css3/infinite-word-spacing.html.
+
+        Move the definitions of minValueForCssLength and maxValueForCssLength from the
+        .cpp file to the .h file.
+        * css/CSSPrimitiveValue.cpp:
+        * css/CSSPrimitiveValue.h:
+
+        Clamp the wordSpacing value to minValueForCssLength and maxValueForCssLength when
+        its type is percentage.
+        * css/DeprecatedStyleBuilder.cpp:
+        (WebCore::ApplyPropertyWordSpacing::applyValue):
+
 2014-10-24  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/css/CSSPrimitiveValue.cpp

@@ -34 +34 @@
 #include "ExceptionCode.h"
 #include "Font.h"
-#include "LayoutUnit.h"
 #include "Node.h"
 #include "Pair.h"
@@ -59 +58 @@
 
 namespace WebCore {
-
-// Max/min values for CSS, needs to slightly smaller/larger than the true max/min values to allow for rounding without overflowing.
-// Subtract two (rather than one) to allow for values to be converted to float and back without exceeding the LayoutUnit::max.
-const int maxValueForCssLength = intMaxForLayoutUnit - 2;
-const int minValueForCssLength = intMinForLayoutUnit + 2;
 
 static inline bool isValidCSSUnitTypeForDoubleConversion(CSSPrimitiveValue::UnitTypes unitType)

trunk/Source/WebCore/css/CSSPrimitiveValue.h

@@ -27 +27 @@
 #include "CSSValueKeywords.h"
 #include "Color.h"
+#include "LayoutUnit.h"
 #include <wtf/Forward.h>
 #include <wtf/MathExtras.h>
@@ -50 +51 @@
 struct Length;
 struct LengthSize;
+
+// Max/min values for CSS, needs to slightly smaller/larger than the true max/min values to allow for rounding without overflowing.
+// Subtract two (rather than one) to allow for values to be converted to float and back without exceeding the LayoutUnit::max.
+const int maxValueForCssLength = intMaxForLayoutUnit - 2;
+const int minValueForCssLength = intMinForLayoutUnit + 2;
 
 // Dimension calculations are imprecise, often resulting in values of e.g.

trunk/Source/WebCore/css/DeprecatedStyleBuilder.cpp

@@ -1497 +1497 @@
             wordSpacing = primitiveValue.computeLength<Length>(csstoLengthConversionDataWithTextZoomFactor(*styleResolver));
         } else if (primitiveValue.isPercentage())
-            wordSpacing = Length(primitiveValue.getDoubleValue(), Percent);
+            wordSpacing = Length(clampTo<float>(primitiveValue.getDoubleValue(), minValueForCssLength, maxValueForCssLength), Percent);
         else if (primitiveValue.isNumber())
             wordSpacing = Length(primitiveValue.getDoubleValue(), Fixed);