Changeset 175395 in webkit

Timestamp:

Oct 30, 2014, 4:26:17 PM (12 years ago)

Author:

Simon Fraser

Message:

Short-circuit repaints with empty rects
​https://bugs.webkit.org/show_bug.cgi?id=138234

Reviewed by Zalan Bujtas.

Repaints with an empty rectangle are common enough that it's worth
short-circuiting them.

• rendering/RenderObject.cpp:

(WebCore::RenderObject::repaintUsingContainer):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/RenderObject.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-10-30  Simon Fraser  <simon.fraser@apple.com>
+
+        Short-circuit repaints with empty rects
+        https://bugs.webkit.org/show_bug.cgi?id=138234
+
+        Reviewed by Zalan Bujtas.
+        
+        Repaints with an empty rectangle are common enough that it's worth
+        short-circuiting them.
+
+        * rendering/RenderObject.cpp:
+        (WebCore::RenderObject::repaintUsingContainer):
+
 2014-10-30  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/rendering/RenderObject.cpp

@@ -1233 +1233 @@
 void RenderObject::repaintUsingContainer(const RenderLayerModelObject* repaintContainer, const LayoutRect& r, bool shouldClipToLayer) const
 {
+    if (r.isEmpty())
+        return;
+
     if (!repaintContainer) {
         view().repaintViewRectangle(r);