Changeset 175477 in webkit

Timestamp:

Nov 3, 2014, 11:19:55 AM (12 years ago)

Author:

ap@apple.com

Message:

REGRESSION: Using a media element changes window.name
​https://bugs.webkit.org/show_bug.cgi?id=138278
rdar://problem/18704134

Apply the same fix to mediaControlsBase.js. I do not know who uses this file, but
there is no reason to have the bug there.

• Modules/mediacontrols/mediaControlsBase.js:

(Controller.prototype.addVideoListeners):
(Controller.prototype.removeVideoListeners):
(Controller.prototype.disconnectControls):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• Modules/mediacontrols/mediaControlsBase.js (modified) (3 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-11-03  Alexey Proskuryakov  <ap@apple.com>
+
+        REGRESSION: Using a media element changes window.name
+        https://bugs.webkit.org/show_bug.cgi?id=138278
+        rdar://problem/18704134
+
+        Apply the same fix to mediaControlsBase.js. I do not know who uses this file, but
+        there is no reason to have the bug there.
+
+        * Modules/mediacontrols/mediaControlsBase.js:
+        (Controller.prototype.addVideoListeners):
+        (Controller.prototype.removeVideoListeners):
+        (Controller.prototype.disconnectControls):
+
 2014-11-03  Andreas Kling  <akling@apple.com>
 

trunk/Source/WebCore/Modules/mediacontrols/mediaControlsBase.js

@@ -156 +156 @@
     addVideoListeners: function()
     {
-        for (name in this.HandledVideoEvents) {
+        for (var name in this.HandledVideoEvents) {
             this.listenFor(this.video, name, this.HandledVideoEvents[name]);
         };
@@ -182 +182 @@
     removeVideoListeners: function()
     {
-        for (name in this.HandledVideoEvents) {
+        for (var name in this.HandledVideoEvents) {
             this.stopListeningFor(this.video, name, this.HandledVideoEvents[name]);
         };
@@ -438 +438 @@
     disconnectControls: function(event)
     {
-        for (item in this.controls) {
+        for (var item in this.controls) {
             var control = this.controls[item];
             if (control && control.parentNode)