Changeset 175602 in webkit

Timestamp:

Nov 4, 2014, 7:58:19 PM (12 years ago)

Author:

Chris Dumez

Message:

Avoid double hash table lookup in SpaceSplitStringData::create()
​https://bugs.webkit.org/show_bug.cgi?id=138396

Reviewed by Ryosuke Niwa.

Avoid double hash table lookup in SpaceSplitStringData::create() by
calling HashMap::add() and using the AddResult, instead of calling
HashMap::get() then HashMap::add().

No new tests, no behavior change.

• dom/SpaceSplitString.cpp:

(WebCore::SpaceSplitStringData::create):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• dom/SpaceSplitString.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-11-04  Chris Dumez  <cdumez@apple.com>
+
+        Avoid double hash table lookup in SpaceSplitStringData::create()
+        https://bugs.webkit.org/show_bug.cgi?id=138396
+
+        Reviewed by Ryosuke Niwa.
+
+        Avoid double hash table lookup in SpaceSplitStringData::create() by
+        calling HashMap::add() and using the AddResult, instead of calling
+        HashMap::get() then HashMap::add().
+
+        No new tests, no behavior change.
+
+        * dom/SpaceSplitString.cpp:
+        (WebCore::SpaceSplitStringData::create):
+
 2014-11-04  Zalan Bujtas  <zalan@apple.com>
 

trunk/Source/WebCore/dom/SpaceSplitString.cpp

@@ -197 +197 @@
     ASSERT(!keyString.isNull());
 
-    auto& table = spaceSplitStringTable();
-    if (SpaceSplitStringData* data = table.get(keyString))
-        return data;
+    auto addResult = spaceSplitStringTable().add(keyString, nullptr);
+    if (!addResult.isNewEntry)
+        return addResult.iterator->value;
 
     // Nothing in the cache? Let's create a new SpaceSplitStringData if the input has something useful.
@@ -211 +211 @@
 
     RefPtr<SpaceSplitStringData> spaceSplitStringData = create(keyString, tokenCount);
-    table.add(keyString, spaceSplitStringData.get());
+    addResult.iterator->value = spaceSplitStringData.get();
     return spaceSplitStringData.release();
 }