⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 175962 in webkit


Ignore:
Timestamp:
Nov 11, 2014, 11:14:07 AM (12 years ago)
Author:
timothy_horton@apple.com
Message:

Localize strings for action menus
​https://bugs.webkit.org/show_bug.cgi?id=138591
<rdar://problem/18815343>

Reviewed by Dan Bates.

  • English.lproj/Localizable.strings:

Add a bunch of localizable strings.

  • WebView/WebActionMenuController.mm:

(-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
Make use of the new strings.

  • UIProcess/mac/WKActionMenuController.mm:

(-[WKActionMenuController _showTextIndicator]):
(-[WKActionMenuController _hideTextIndicator]):
(-[WKActionMenuController _createActionMenuItemForTag:]):
Make use of the new strings.

Location:
trunk/Source
Files:
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r175961 r175962  
     12014-11-11  Tim Horton  <timothy_horton@apple.com>
     2
     3        Localize strings for action menus
     4        https://bugs.webkit.org/show_bug.cgi?id=138591
     5        <rdar://problem/18815343>
     6
     7        Reviewed by Dan Bates.
     8
     9        * English.lproj/Localizable.strings:
     10        Add a bunch of localizable strings.
     11
    1122014-11-11  Myles C. Maxfield  <mmaxfield@apple.com>
    213

  • trunk/Source/WebCore/English.lproj/Localizable.strings

    r173929 r175962  
    10761076"video playback" = "video playback";
    10771077
     1078/* "Open Link in Default Browser" action menu item */
     1079"Open (action menu item)" = "Open";
     1080
     1081/* "Preview Link" action menu item */
     1082"Preview (action menu item)" = "Preview";
     1083
     1084/* "Add to Reading List" action menu item */
     1085"Add to Reading List (action menu item)" = "Add to Reading List";
     1086
     1087/* "Copy" action menu item in image menu */
     1088"Copy (image action menu item)" = "Copy";
     1089
     1090/* "Add to Photos" action menu item */
     1091"Add to Photos (action menu item)" = "Add to Photos";
     1092
     1093/* "Save to Downloads" action menu item in image menu */
     1094"Save to Downloads (image action menu item)" = "Save to Downloads";
     1095
     1096/* "Share" action menu item in image menu */
     1097"Share (image action menu item)" = "Share";
     1098
     1099/* "Copy" action menu item in text menu */
     1100"Copy (text action menu item)" = "Copy";
     1101
     1102/* "Look Up" action menu item */
     1103"Look Up (action menu item)" = "Look Up";
     1104
     1105/* "Paste" action menu item */
     1106"Paste (action menu item)" = "Paste";
     1107
     1108/* "Suggestions" action menu item */
     1109"Suggestions (action menu item)" = "Suggestions";
     1110
     1111/* "Copy" action menu item in video menu */
     1112"Copy (video action menu item)" = "Copy";
     1113
     1114/* "Share" action menu item in video menu */
     1115"Share (video action menu item)" = "Share";
     1116
     1117/* "Save to Downloads" action menu item in video menu */
     1118"Save to Downloads (video action menu item)" = "Save to Downloads";

  • trunk/Source/WebKit/mac/ChangeLog

    r175961 r175962  
     12014-11-11  Tim Horton  <timothy_horton@apple.com>
     2
     3        Localize strings for action menus
     4        https://bugs.webkit.org/show_bug.cgi?id=138591
     5        <rdar://problem/18815343>
     6
     7        Reviewed by Dan Bates.
     8
     9        * WebView/WebActionMenuController.mm:
     10        (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
     11        Make use of the new strings.
     12
    1132014-11-11  Myles C. Maxfield  <mmaxfield@apple.com>
    214

  • trunk/Source/WebKit/mac/WebView/WebActionMenuController.mm

    r175842 r175962  
    442442    id representedObject = nil;
    443443
    444     // FIXME: We should localize these strings.
    445444    switch (tag) {
    446445    case WebActionMenuItemTagOpenLinkInDefaultBrowser:
    447446        selector = @selector(_openURLFromActionMenu:);
    448         title = @"Open";
     447        title = WEB_UI_STRING_KEY("Open", "Open (action menu item)", "action menu item");
    449448        image = webKitBundleImageNamed(@"OpenInNewWindowTemplate");
    450449        representedObject = [hitTestResult objectForKey:WebElementLinkURLKey];
    … …  
    453452    case WebActionMenuItemTagPreviewLink:
    454453        selector = @selector(_quickLookURLFromActionMenu:);
    455         title = @"Preview";
     454        title = WEB_UI_STRING_KEY("Preview", "Preview (action menu item)", "action menu item");
    456455        image = [NSImage imageNamed:@"NSActionMenuQuickLook"];
    457456        representedObject = hitTestResult;
    … …  
    460459    case WebActionMenuItemTagAddLinkToSafariReadingList:
    461460        selector = @selector(_addToReadingListFromActionMenu:);
    462         title = @"Add to Safari Reading List";
     461        title = WEB_UI_STRING_KEY("Add to Reading List", "Add to Reading List (action menu item)", "action menu item");
    463462        image = [NSImage imageNamed:NSImageNameBookmarksTemplate];
    464463        representedObject = [hitTestResult objectForKey:WebElementLinkURLKey];
    … …  
    467466    case WebActionMenuItemTagCopyText:
    468467        selector = @selector(_copySelection:);
    469         title = @"Copy";
     468        title = WEB_UI_STRING_KEY("Copy", "Copy (text action menu item)", "text action menu item");
    470469        image = [NSImage imageNamed:@"NSActionMenuCopy"];
    471470        break;
    … …  
    473472    case WebActionMenuItemTagLookupText:
    474473        selector = @selector(_lookupText:);
    475         title = @"Look Up";
     474        title = WEB_UI_STRING_KEY("Look Up", "Look Up (action menu item)", "action menu item");
    476475        image = [NSImage imageNamed:@"NSActionMenuLookup"];
    477476        break;
    … …  
    479478    case WebActionMenuItemTagPaste:
    480479        selector = @selector(_paste:);
    481         title = @"Paste";
     480        title = WEB_UI_STRING_KEY("Paste", "Paste (action menu item)", "action menu item");
    482481        image = [NSImage imageNamed:@"NSActionMenuPaste"];
    483482        break;
    484483
    485484    case WebActionMenuItemTagTextSuggestions:
    486         title = @"Suggestions";
     485        title = WEB_UI_STRING_KEY("Suggestions", "Suggestions (action menu item)", "action menu item");
    487486        image = [NSImage imageNamed:@"NSActionMenuSpelling"];
    488487        break;

  • trunk/Source/WebKit2/ChangeLog

    r175961 r175962  
     12014-11-11  Tim Horton  <timothy_horton@apple.com>
     2
     3        Localize strings for action menus
     4        https://bugs.webkit.org/show_bug.cgi?id=138591
     5        <rdar://problem/18815343>
     6
     7        Reviewed by Dan Bates.
     8
     9        * UIProcess/mac/WKActionMenuController.mm:
     10        (-[WKActionMenuController _showTextIndicator]):
     11        (-[WKActionMenuController _hideTextIndicator]):
     12        (-[WKActionMenuController _createActionMenuItemForTag:]):
     13        Make use of the new strings.
     14
    1152014-11-11  Myles C. Maxfield  <mmaxfield@apple.com>
    216

  • trunk/Source/WebKit2/UIProcess/mac/WKActionMenuController.mm

    r175835 r175962  
    4545#import <WebCore/DataDetectorsSPI.h>
    4646#import <WebCore/GeometryUtilities.h>
     47#import <WebCore/LocalizedStrings.h>
    4748#import <WebCore/NSSharingServiceSPI.h>
    4849#import <WebCore/NSSharingServicePickerSPI.h>
    … …  
    724725    NSImage *image = nil;
    725726
    726     // FIXME: These titles need to be localized.
    727727    switch (tag) {
    728728    case kWKContextActionItemTagOpenLinkInDefaultBrowser:
    729729        selector = @selector(_openURLFromActionMenu:);
    730         title = @"Open";
     730        title = WEB_UI_STRING_KEY("Open", "Open (action menu item)", "action menu item");
    731731        image = webKitBundleImageNamed(@"OpenInNewWindowTemplate");
    732732        break;
    … …  
    735735    case kWKContextActionItemTagPreviewLink:
    736736        selector = @selector(_keepPreviewOpenFromActionMenu:);
    737         title = @"Preview";
     737        title = WEB_UI_STRING_KEY("Preview", "Preview (action menu item)", "action menu item");
    738738        image = [NSImage imageNamed:@"NSActionMenuQuickLook"];
    739739        break;
    … …  
    742742    case kWKContextActionItemTagAddLinkToSafariReadingList:
    743743        selector = @selector(_addToReadingListFromActionMenu:);
    744         title = @"Add to Safari Reading List";
     744        title = WEB_UI_STRING_KEY("Add to Reading List", "Add to Reading List (action menu item)", "action menu item");
    745745        image = [NSImage imageNamed:NSImageNameBookmarksTemplate];
    746746        break;
    … …  
    748748    case kWKContextActionItemTagCopyImage:
    749749        selector = @selector(_copyImage:);
    750         title = @"Copy";
     750        title = WEB_UI_STRING_KEY("Copy", "Copy (image action menu item)", "image action menu item");
    751751        image = [NSImage imageNamed:@"NSActionMenuCopy"];
    752752        break;
    … …  
    754754    case kWKContextActionItemTagAddImageToPhotos:
    755755        selector = @selector(_addImageToPhotos:);
    756         title = @"Add to Photos";
     756        title = WEB_UI_STRING_KEY("Add to Photos", "Add to Photos (action menu item)", "action menu item");
    757757        image = [NSImage imageNamed:@"NSActionMenuAddToPhotos"];
    758758        break;
    … …  
    760760    case kWKContextActionItemTagSaveImageToDownloads:
    761761        selector = @selector(_saveImageToDownloads:);
    762         title = @"Save to Downloads";
     762        title = WEB_UI_STRING_KEY("Save to Downloads", "Save to Downloads (image action menu item)", "image action menu item");
    763763        image = [NSImage imageNamed:@"NSActionMenuSaveToDownloads"];
    764764        break;
    765765
    766766    case kWKContextActionItemTagShareImage:
    767         title = @"Share";
     767        title = WEB_UI_STRING_KEY("Share (image action menu item)", "Share (image action menu item)", "image action menu item");
    768768        image = [NSImage imageNamed:@"NSActionMenuShare"];
    769769        break;
    … …  
    771771    case kWKContextActionItemTagCopyText:
    772772        selector = @selector(_copySelection:);
    773         title = @"Copy";
     773        title = WEB_UI_STRING_KEY("Copy", "Copy (text action menu item)", "text action menu item");
    774774        image = [NSImage imageNamed:@"NSActionMenuCopy"];
    775775        break;
    … …  
    777777    case kWKContextActionItemTagLookupText:
    778778        selector = @selector(_lookupText:);
    779         title = @"Look Up";
     779        title = WEB_UI_STRING_KEY("Look Up", "Look Up (action menu item)", "action menu item");
    780780        image = [NSImage imageNamed:@"NSActionMenuLookup"];
    781781        break;
    … …  
    783783    case kWKContextActionItemTagPaste:
    784784        selector = @selector(_paste:);
    785         title = @"Paste";
     785        title = WEB_UI_STRING_KEY("Paste", "Paste (action menu item)", "action menu item");
    786786        image = [NSImage imageNamed:@"NSActionMenuPaste"];
    787787        break;
    788788
    789789    case kWKContextActionItemTagTextSuggestions:
    790         title = @"Suggestions";
     790        title = WEB_UI_STRING_KEY("Suggestions", "Suggestions (action menu item)", "action menu item");
    791791        image = [NSImage imageNamed:@"NSActionMenuSpelling"];
    792792        break;
    … …  
    794794    case kWKContextActionItemTagCopyVideoURL:
    795795        selector = @selector(_copyVideoURL:);
    796         title = @"Copy";
     796        title = WEB_UI_STRING_KEY("Copy", "Copy (video action menu item)", "video action menu item");
    797797        image = [NSImage imageNamed:@"NSActionMenuCopy"];
    798798        break;
    … …  
    800800    case kWKContextActionItemTagSaveVideoToDownloads:
    801801        selector = @selector(_saveVideoToDownloads:);
    802         title = @"Save to Downloads";
     802        title = WEB_UI_STRING_KEY("Share", "Share (video action menu item)", "video action menu item");
    803803        image = [NSImage imageNamed:@"NSActionMenuSaveToDownloads"];
    804804        break;
    805805
    806806    case kWKContextActionItemTagShareVideo:
    807         title = @"Share";
     807        title = WEB_UI_STRING_KEY("Save to Downloads", "Save to Downloads (video action menu item)", "video action menu item");
    808808        image = [NSImage imageNamed:@"NSActionMenuShare"];
    809809        break;
Note: See TracChangeset for help on using the changeset viewer.