⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 175977 in webkit


Ignore:
Timestamp:
Nov 11, 2014, 2:20:31 PM (12 years ago)
Author:
jonowells@apple.com
Message:

Web Inspector: Main.js missing many trailing semicolons
https://bugs.webkit.org/show_bug.cgi?id=138624

Add semicolons to function variable assignments.

Reviewed by Timothy Hatcher.

  • UserInterface/Base/Main.js: Added semicolons.
Location:
trunk/Source/WebInspectorUI
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebInspectorUI/ChangeLog

    r175850 r175977  
     12014-11-11  Jonathan Wells  <jonowells@apple.com>
     2
     3        Web Inspector: Main.js missing many trailing semicolons
     4        https://bugs.webkit.org/show_bug.cgi?id=138624
     5
     6        Add semicolons to function variable assignments.
     7
     8        Reviewed by Timothy Hatcher.
     9
     10        * UserInterface/Base/Main.js: Added semicolons.
     11
    1122014-11-10  Jonathan Wells  <jonowells@apple.com>
    213
  • trunk/Source/WebInspectorUI/UserInterface/Base/Main.js

    r175838 r175977  
    3131    DOMStorage: "dom-storage",
    3232    Resource: "resource", // includes Frame too.
    33     Timelines: "timelines",
     33    Timelines: "timelines"
    3434};
    3535
     
    354354
    355355    this._contentLoaded = true;
    356 }
     356};
    357357
    358358WebInspector.activateExtraDomains = function(domains)
     
    370370
    371371    WebInspector.CSSCompletions.requestCSSNameCompletions();
    372 }
     372};
    373373
    374374WebInspector.sidebarPanelForCurrentContentView = function()
     
    378378        return null;
    379379    return this.sidebarPanelForRepresentedObject(currentContentView.representedObject);
    380 }
     380};
    381381
    382382WebInspector.sidebarPanelForRepresentedObject = function(representedObject)
     
    401401    console.error("Unknown representedObject: ", representedObject);
    402402    return null;
    403 }
     403};
    404404
    405405WebInspector.contentBrowserTreeElementForRepresentedObject = function(contentBrowser, representedObject)
     
    413413        return sidebarPanel.treeElementForRepresentedObject(representedObject);
    414414    return null;
    415 }
     415};
    416416
    417417WebInspector.updateWindowTitle = function()
     
    442442    // used for updating the window title and it can be any string.
    443443    InspectorFrontendHost.inspectedURLChanged(title);
    444 }
     444};
    445445
    446446WebInspector.updateDockedState = function(side)
     
    486486    this._updateDockNavigationItems();
    487487    this._updateToolbarHeight();
    488 }
     488};
    489489
    490490WebInspector.handlePossibleLinkClick = function(event, frame, alwaysOpenExternally)
     
    506506
    507507    return true;
    508 }
     508};
    509509
    510510WebInspector.openURL = function(url, frame, alwaysOpenExternally, lineNumber)
     
    540540
    541541    InspectorFrontendHost.openInNewTab(url);
    542 }
     542};
    543543
    544544WebInspector.close = function()
     
    550550
    551551    InspectorFrontendHost.closeWindow();
    552 }
     552};
    553553
    554554WebInspector.isConsoleFocused = function()
    555555{
    556556    return this.quickConsole.prompt.focused;
    557 }
     557};
    558558
    559559WebInspector.isShowingSplitConsole = function()
    560560{
    561561    return !this.splitContentBrowser.element.classList.contains("hidden");
    562 }
     562};
    563563
    564564WebInspector.currentViewSupportsSplitContentBrowser = function()
     
    566566    var currentContentView = this.contentBrowser.currentContentView;
    567567    return !currentContentView || currentContentView.supportsSplitContentBrowser;
    568 }
     568};
    569569
    570570WebInspector.toggleSplitConsole = function()
     
    579579    else
    580580        this.showSplitConsole();
    581 }
     581};
    582582
    583583WebInspector.showSplitConsole = function()
     
    606606
    607607    this.quickConsole.consoleLogVisibilityChanged(true);
    608 }
     608};
    609609
    610610WebInspector.hideSplitConsole = function()
     
    618618
    619619    this.quickConsole.consoleLogVisibilityChanged(false);
    620 }
     620};
    621621
    622622WebInspector.showFullHeightConsole = function(scope)
     
    657657
    658658    this.quickConsole.consoleLogVisibilityChanged(true);
    659 }
     659};
    660660
    661661WebInspector.isShowingConsoleView = function()
    662662{
    663663    return this.contentBrowser.currentContentView instanceof WebInspector.LogContentView;
    664 }
     664};
    665665
    666666WebInspector.showConsoleView = function(scope)
    667667{
    668668    this.showFullHeightConsole(scope);
    669 }
     669};
    670670
    671671WebInspector.toggleConsoleView = function()
     
    684684    } else
    685685        this.showFullHeightConsole();
    686 }
     686};
    687687
    688688WebInspector.UIString = function(string, vararg)
     
    703703
    704704    return "LOCALIZED STRING NOT FOUND";
    705 }
     705};
    706706
    707707WebInspector.restoreFocusFromElement = function(element)
     
    709709    if (element && element.isSelfOrAncestor(this.currentFocusElement))
    710710        this.previousFocusElement.focus();
    711 }
     711};
    712712
    713713WebInspector._focusChanged = function(event)
     
    740740    selection.removeAllRanges();
    741741    selection.addRange(selectionRange);
    742 }
     742};
    743743
    744744WebInspector._mouseWasClicked = function(event)
    745745{
    746746    this.handlePossibleLinkClick(event);
    747 }
     747};
    748748
    749749WebInspector._dragOver = function(event)
     
    760760    event.dataTransfer.dropEffect = "none";
    761761    event.preventDefault();
    762 }
     762};
    763763
    764764WebInspector._captureDidStart = function(event)
    765765{
    766766    this.dashboardContainer.showDashboardViewForRepresentedObject(this.dashboardManager.dashboards.replay);
    767 }
     767};
    768768
    769769WebInspector._debuggerDidPause = function(event)
     
    777777
    778778    InspectorFrontendHost.bringToFront();
    779 }
     779};
    780780
    781781WebInspector._debuggerDidResume = function(event)
    782782{
    783783    this.dashboardContainer.closeDashboardViewForRepresentedObject(this.dashboardManager.dashboards.debugger);
    784 }
     784};
    785785
    786786WebInspector._mainFrameDidChange = function(event)
    787787{
    788788    this.updateWindowTitle();
    789 }
     789};
    790790
    791791WebInspector._mainResourceDidChange = function(event)
     
    799799
    800800    this.updateWindowTitle();
    801 }
     801};
    802802
    803803WebInspector._provisionalLoadStarted = function(event)
     
    809809
    810810    this._inProvisionalLoad = true;
    811 }
     811};
    812812
    813813WebInspector._windowFocused = function(event)
     
    818818    // FIXME: We should use the :window-inactive pseudo class once https://webkit.org/b/38927 is fixed.
    819819    document.body.classList.remove("window-inactive");
    820 }
     820};
    821821
    822822WebInspector._windowBlurred = function(event)
     
    827827    // FIXME: We should use the :window-inactive pseudo class once https://webkit.org/b/38927 is fixed.
    828828    document.body.classList.add("window-inactive");
    829 }
     829};
    830830
    831831WebInspector._windowResized = function(event)
     
    834834
    835835    this._contentBrowserSizeDidChange(event);
    836 }
     836};
    837837
    838838WebInspector._updateModifierKeys = function(event)
     
    844844    if (didChange)
    845845        this.notifications.dispatchEventToListeners(WebInspector.Notification.GlobalModifierKeysDidChange, event);
    846 }
     846};
    847847
    848848WebInspector._windowKeyDown = function(event)
     
    852852    var opposite = !this._dockButtonToggledSetting.value;
    853853    this.undockButtonNavigationItem.toggled = (event.altKey && !event.metaKey && !event.shiftKey) ? opposite : !opposite;
    854 }
     854};
    855855
    856856WebInspector._windowKeyUp = function(event)
     
    860860    var opposite = !this._dockButtonToggledSetting.value;
    861861    this.undockButtonNavigationItem.toggled = (event.altKey && !event.metaKey && !event.shiftKey) ? opposite : !opposite;
    862 }
     862};
    863863
    864864WebInspector._mouseMoved = function(event)
     
    869869        y: event.pageY
    870870    };
    871 }
     871};
    872872
    873873WebInspector._pageHidden = function(event)
    874874{
    875875    this._updateCookieForInspectorViewState();
    876 }
     876};
    877877
    878878WebInspector._undock = function(event)
     
    884884    else
    885885        InspectorFrontendHost.requestSetDockSide("undocked");
    886 }
     886};
    887887
    888888WebInspector._updateDockNavigationItems = function()
     
    899899
    900900    this.undockButtonNavigationItem.toggled = this._dockButtonToggledSetting.value;
    901 }
     901};
    902902
    903903WebInspector._sidebarCollapsedStateDidChange = function(event)
     
    910910            this._detailsSidebarCollapsedSetting.value = this.detailsSidebar.collapsed;
    911911    }
    912 }
     912};
    913913
    914914WebInspector._detailsSidebarPanelSelected = function(event)
     
    918918
    919919    this._lastSelectedDetailsSidebarPanelSetting.value = this.detailsSidebar.selectedSidebarPanel.identifier;
    920 }
     920};
    921921
    922922WebInspector._revealAndSelectRepresentedObjectInNavigationSidebar = function(representedObject)
     
    946946    if (!selectedSidebarPanel.hasSelectedElement)
    947947        selectedSidebarPanel.showDefaultContentView();
    948 }
     948};
    949949
    950950WebInspector._updateNavigationSidebarForCurrentContentView = function()
     
    975975
    976976    this._revealAndSelectRepresentedObjectInNavigationSidebar(currentContentView.representedObject);
    977 }
     977};
    978978
    979979WebInspector._navigationSidebarPanelSelected = function(event)
     
    984984
    985985    this._updateNavigationSidebarForCurrentContentView();
    986 }
     986};
    987987
    988988WebInspector._domNodeWasInspected = function(event)
     
    995995
    996996    InspectorFrontendHost.bringToFront();
    997 }
     997};
    998998
    999999WebInspector._contentBrowserSizeDidChange = function(event)
     
    10021002    this.splitContentBrowser.updateLayout();
    10031003    this.quickConsole.updateLayout();
    1004 }
     1004};
    10051005
    10061006WebInspector._quickConsoleDidResize = function(event)
    10071007{
    10081008    this.contentBrowser.updateLayout();
    1009 }
     1009};
    10101010
    10111011WebInspector._sidebarWidthDidChange = function(event)
     
    10191019
    10201020    this._contentBrowserSizeDidChange(event);
    1021 }
     1021};
    10221022
    10231023WebInspector._updateToolbarHeight = function()
     
    10251025    if (WebInspector.Platform.isLegacyMacOS)
    10261026        InspectorFrontendHost.setToolbarHeight(this.toolbar.element.offsetHeight);
    1027 }
     1027};
    10281028
    10291029WebInspector._toolbarDisplayModeDidChange = function(event)
     
    10401040
    10411041    this._updateToolbarHeight();
    1042 }
     1042};
    10431043
    10441044WebInspector._toolbarSizeModeDidChange = function(event)
     
    10551055
    10561056    this._updateToolbarHeight();
    1057 }
     1057};
    10581058
    10591059WebInspector._updateCookieForInspectorViewState = function()
     
    10851085    selectedSidebarPanel.saveStateToCookie(cookie);
    10861086    this._lastInspectorViewStateCookieSetting.value = cookie;
    1087 }
     1087};
    10881088
    10891089WebInspector._contentBrowserCurrentContentViewDidChange = function(event)
     
    11201120
    11211121    this._revealAndSelectRepresentedObjectInNavigationSidebar(currentContentView.representedObject);
    1122 }
     1122};
    11231123
    11241124WebInspector._contentBrowserRepresentedObjectsDidChange = function(event)
     
    11781178    // Stop ignoring the sidebar panel selected event.
    11791179    delete this._ignoreDetailsSidebarPanelSelectedEvent;
    1180 }
     1180};
    11811181
    11821182WebInspector._restoreInspectorViewStateFromCookie = function(cookie, causedByReload)
     
    12071207    var relaxMatchDelay = causedByReload ? matchTypeOnlyDelayForReload : matchTypeOnlyDelayForReopen;
    12081208    sidebarPanel.restoreStateFromCookie(cookie, relaxMatchDelay);
    1209 }
     1209};
    12101210
    12111211WebInspector._initializeWebSocketIfNeeded = function()
     
    12281228
    12291229    InspectorFrontendHost.initializeWebSocket(url);
    1230 }
     1230};
    12311231
    12321232WebInspector._updateSplitConsoleHeight = function(height)
     
    12381238
    12391239    this.splitContentBrowser.element.style.height = height + "px";
    1240 }
     1240};
    12411241
    12421242WebInspector._consoleResizerMouseDown = function(event)
     
    12731273
    12741274    this.elementDragStart(resizerElement, dockedResizerDrag.bind(this), dockedResizerDragEnd.bind(this), event, "row-resize");
    1275 }
     1275};
    12761276
    12771277WebInspector._toolbarMouseDown = function(event)
     
    12871287    else
    12881288        this._moveWindowMouseDown(event);
    1289 }
     1289};
    12901290
    12911291WebInspector._dockedResizerMouseDown = function(event)
     
    13481348
    13491349    WebInspector.elementDragStart(resizerElement, dockedResizerDrag.bind(this), dockedResizerDragEnd.bind(this), event, this._dockSide === "bottom" ? "row-resize" : "col-resize");
    1350 }
     1350};
    13511351
    13521352WebInspector._moveWindowMouseDown = function(event)
     
    13951395
    13961396    WebInspector.elementDragStart(event.target, toolbarDrag, toolbarDragEnd, event, "default");
    1397 }
     1397};
    13981398
    13991399WebInspector._inspectModeStateChanged = function(event)
    14001400{
    14011401    this._inspectModeToolbarButton.activated = WebInspector.domTreeManager.inspectModeEnabled;
    1402 }
     1402};
    14031403
    14041404WebInspector._toggleInspectMode = function(event)
    14051405{
    14061406    WebInspector.domTreeManager.inspectModeEnabled = !WebInspector.domTreeManager.inspectModeEnabled;
    1407 }
     1407};
    14081408
    14091409WebInspector._reloadPage = function(event)
    14101410{
    14111411    PageAgent.reload();
    1412 }
     1412};
    14131413
    14141414WebInspector._reloadPageIgnoringCache = function(event)
    14151415{
    14161416    PageAgent.reload(true);
    1417 }
     1417};
    14181418
    14191419WebInspector._toggleInspectMode = function(event)
    14201420{
    14211421    this.domTreeManager.inspectModeEnabled = !this.domTreeManager.inspectModeEnabled;
    1422 }
     1422};
    14231423
    14241424WebInspector._focusedContentView = function()
     
    14291429        return  this.splitContentBrowser.currentContentView;
    14301430    return null;
    1431 }
     1431};
    14321432
    14331433WebInspector._beforecopy = function(event)
     
    14581458    // Say we can handle it (by preventing default) to remove word break characters.
    14591459    event.preventDefault();
    1460 }
     1460};
    14611461
    14621462WebInspector._copy = function(event)
     
    14891489    event.clipboardData.setData("text/plain", selectionString);
    14901490    event.preventDefault();
    1491 }
     1491};
    14921492
    14931493WebInspector._generateDisclosureTriangleImages = function()
     
    15041504    generateColoredImagesForCSS("Images/DisclosureTriangleTinyOpen.svg", specifications, 8, 8, "disclosure-triangle-tiny-open-");
    15051505    generateColoredImagesForCSS("Images/DisclosureTriangleTinyClosed.svg", specifications, 8, 8, "disclosure-triangle-tiny-closed-");
    1506 }
     1506};
    15071507
    15081508WebInspector.elementDragStart = function(element, dividerDrag, elementDragEnd, event, cursor, eventTarget)
     
    15351535
    15361536    event.preventDefault();
    1537 }
     1537};
    15381538
    15391539WebInspector.elementDragEnd = function(event)
     
    15531553
    15541554    event.preventDefault();
    1555 }
     1555};
    15561556
    15571557WebInspector.createMessageTextView = function(message, isError)
     
    15651565
    15661566    return messageElement;
    1567 }
     1567};
    15681568
    15691569WebInspector.createGoToArrowButton = function()
     
    15911591    button.tabIndex = -1;
    15921592    return button;
    1593 }
     1593};
    15941594
    15951595WebInspector.createSourceCodeLocationLink = function(sourceCodeLocation, dontFloat, useGoToArrowButton)
     
    16241624
    16251625    return linkElement;
    1626 }
     1626};
    16271627
    16281628WebInspector.linkifyLocation = function(url, lineNumber, columnNumber, className)
     
    16501650        linkElement.classList.add(className);
    16511651    return linkElement;
    1652 }
     1652};
    16531653
    16541654WebInspector.linkifyURLAsNode = function(url, linkText, classes, tooltipText)
     
    16721672
    16731673    return a;
    1674 }
     1674};
    16751675
    16761676WebInspector.linkifyStringAsFragmentWithCustomLinkifier = function(string, linkifier)
     
    17051705
    17061706    return container;
    1707 }
     1707};
    17081708
    17091709WebInspector.linkifyStringAsFragment = function(string)
     
    17191719
    17201720    return WebInspector.linkifyStringAsFragmentWithCustomLinkifier(string, linkifier);
    1721 }
     1721};
    17221722
    17231723WebInspector._undoKeyboardShortcut = function(event)
     
    17271727        event.preventDefault();
    17281728    }
    1729 }
     1729};
    17301730
    17311731WebInspector._redoKeyboardShortcut = function(event)
     
    17351735        event.preventDefault();
    17361736    }
    1737 }
     1737};
    17381738
    17391739WebInspector.undo = function()
    17401740{
    17411741    DOMAgent.undo();
    1742 }
     1742};
    17431743
    17441744WebInspector.redo = function()
    17451745{
    17461746    DOMAgent.redo();
    1747 }
     1747};
    17481748
    17491749WebInspector.highlightRangesWithStyleClass = function(element, resultRanges, styleClass, changes)
     
    18241824    }
    18251825    return highlightNodes;
    1826 }
     1826};
    18271827
    18281828WebInspector.revertDomChanges = function(domChanges)
     
    18401840        }
    18411841    }
    1842 }
     1842};
    18431843
    18441844WebInspector.archiveMainFrame = function()
     
    18581858        }.bind(this));
    18591859    }.bind(this), 3000);
    1860 }
     1860};
    18611861
    18621862WebInspector.canArchiveMainFrame = function()
     
    18661866
    18671867    return WebInspector.Resource.typeFromMIMEType(WebInspector.frameResourceManager.mainFrame.mainResource.mimeType) === WebInspector.Resource.Type.Document;
    1868 }
     1868};
    18691869
    18701870WebInspector.addWindowKeydownListener = function(listener)
     
    18911891    else
    18921892        window.removeEventListener("keydown", WebInspector._sharedWindowKeydownListener, true);
    1893 }
     1893};
    18941894
    18951895WebInspector._sharedWindowKeydownListener = function(event)
Note: See TracChangeset for help on using the changeset viewer.