Changeset 175991 in webkit

Timestamp:

Nov 11, 2014, 4:46:41 PM (12 years ago)

Author:

ddkilzer@apple.com

Message:

webkit-patch --suggest-reviewers is broken with newer versions of git
<​http://webkit.org/b/138627>

Reviewed by Michael Saboff with feedback from Daniel Bates.

• Scripts/webkitpy/common/checkout/scm/git.py:

(Git._changes_files_for_commit): Strip blank lines instead of
assuming there is always a blank line at the beginning of the
list.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/common/checkout/scm/git.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2014-11-11  David Kilzer  <ddkilzer@apple.com>
+
+        webkit-patch --suggest-reviewers is broken with newer versions of git
+        <http://webkit.org/b/138627>
+
+        Reviewed by Michael Saboff with feedback from Daniel Bates.
+
+        * Scripts/webkitpy/common/checkout/scm/git.py:
+        (Git._changes_files_for_commit): Strip blank lines instead of
+        assuming there is always a blank line at the beginning of the
+        list.
+
 2014-11-11  Alexey Proskuryakov  <ap@apple.com>
 

trunk/Tools/Scripts/webkitpy/common/checkout/scm/git.py

@@ -224 +224 @@
 
     def _changes_files_for_commit(self, git_commit):
-        # --pretty="format:" makes git show not print the commit log header,
-        changed_files = self._run_git(["show", "--pretty=format:", "--name-only", git_commit]).splitlines()
-        # instead it just prints a blank line at the top, so we skip the blank line:
-        return changed_files[1:]
+        # --pretty="format:" makes git show not print the commit log header.
+        changed_files = self._run_git(["show", "--pretty=format:", "--name-only", git_commit])
+        # Strip blank lines which could appear at the top on older versions of git.
+        return changed_files.lstrip().splitlines()
 
     def changed_files_for_revision(self, revision):