Changeset 176294 in webkit

Timestamp:

Nov 18, 2014, 4:20:07 PM (12 years ago)

Author:

akling@apple.com

Message:

Avoid synchronous style recalc in Document.activeElement
<​https://webkit.org/b/138850>

Reviewed by Ryosuke Niwa.

Source/WebCore:

This subtly changes the behavior of <input autofocus>, which was caught by
a layout test. Auto-focus doesn't happen until the render tree is attached,
although it was possible to force it by accessing document.activeElement.

Now auto-focus is always lazy. This is consistent with other browser engines.

~1% progression on Speedometer locally.

• dom/Document.cpp:

(WebCore::Document::activeElement):

LayoutTests:

Tweak a test to run once the DOM is loaded instead of during parsing.

• fast/forms/autofocus-in-sandbox-with-allow-scripts.html:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/forms/autofocus-in-sandbox-with-allow-scripts.html (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/dom/Document.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2014-11-18  Andreas Kling  <akling@apple.com>
+
+        Avoid synchronous style recalc in Document.activeElement
+        <https://webkit.org/b/138850>
+
+        Reviewed by Ryosuke Niwa.
+
+        Tweak a test to run once the DOM is loaded instead of during parsing.
+
+        * fast/forms/autofocus-in-sandbox-with-allow-scripts.html:
+
 2014-11-18  David Hyatt  <hyatt@apple.com>
 

trunk/LayoutTests/fast/forms/autofocus-in-sandbox-with-allow-scripts.html

@@ -6 +6 @@
 (which it would be if the sandbox didn't allow autofocus although allow-scripts flag is set).
 <iframe sandbox="allow-scripts"
-    src="data:text/html,<input autofocus onfocus><script>alert(document.activeElement.tagName)</script>"></iframe>
+    src="data:text/html,<input autofocus onfocus><script>window.onload = function() { alert(document.activeElement.tagName) }</script>"></iframe>

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-11-18  Andreas Kling  <akling@apple.com>
+
+        Avoid synchronous style recalc in Document.activeElement
+        <https://webkit.org/b/138850>
+
+        Reviewed by Ryosuke Niwa.
+
+        This subtly changes the behavior of <input autofocus>, which was caught by
+        a layout test. Auto-focus doesn't happen until the render tree is attached,
+        although it was possible to force it by accessing document.activeElement.
+
+        Now auto-focus is always lazy. This is consistent with other browser engines.
+
+        ~1% progression on Speedometer locally.
+
+        * dom/Document.cpp:
+        (WebCore::Document::activeElement):
+
 2014-11-18  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/dom/Document.cpp

@@ -6316 +6316 @@
 Element* Document::activeElement()
 {
-    updateStyleIfNeeded();
     if (Element* element = treeScope().focusedElement())
         return element;