Changeset 176296 in webkit

Timestamp:

Nov 18, 2014, 4:49:33 PM (12 years ago)

Author:

Beth Dakin

Message:

REGRESSION: Invoking dictionary lookup on text in some search fields searches for
incorrect item
​https://bugs.webkit.org/show_bug.cgi?id=138853
-and corresponding-
rdar://problem/18912505

Reviewed by Tim Horton.

Get the visible position based on the frame, not just the renderer.

• editing/mac/DictionaryLookup.mm:

(WebCore::rangeForDictionaryLookupAtHitTestResult):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• editing/mac/DictionaryLookup.mm (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-11-18  Beth Dakin  <bdakin@apple.com>
+
+        REGRESSION: Invoking dictionary lookup on text in some search fields searches for 
+        incorrect item
+        https://bugs.webkit.org/show_bug.cgi?id=138853
+        -and corresponding-
+        rdar://problem/18912505
+
+        Reviewed by Tim Horton.
+
+        Get the visible position based on the frame, not just the renderer.
+        * editing/mac/DictionaryLookup.mm:
+        (WebCore::rangeForDictionaryLookupAtHitTestResult):
+
 2014-11-18  David Hyatt  <hyatt@apple.com>
 

trunk/Source/WebCore/editing/mac/DictionaryLookup.mm

@@ -138 +138 @@
 
     // Don't do anything if there is no character at the point.
-    if (!frame->rangeForPoint(hitTestResult.roundedPointInInnerNodeFrame()))
+    IntPoint framePoint = hitTestResult.roundedPointInInnerNodeFrame();
+    if (!frame->rangeForPoint(framePoint))
         return nullptr;
 
-    VisiblePosition position = renderer->positionForPoint(hitTestResult.localPoint(), nullptr);
+    VisiblePosition position = frame->visiblePositionForPoint(framePoint);
     if (position.isNull())
         position = firstPositionInOrBeforeNode(node);