Changeset 176487 in webkit

Timestamp:

Nov 21, 2014, 4:55:45 PM (12 years ago)

Author:

eric.carlson@apple.com

Message:

WebVideoFullscreenManagerProxy must clear pointers when invalidated
​https://bugs.webkit.org/show_bug.cgi?id=138982

Reviewed by Jer Noble.

• UIProcess/ios/WebVideoFullscreenManagerProxy.mm:

(WebKit::WebVideoFullscreenManagerProxy::~WebVideoFullscreenManagerProxy): Call invalidate.
(WebKit::WebVideoFullscreenManagerProxy::invalidate): Set WebVideoFullscreenModel and

WebVideoFullscreenChangeObserver to NULL.

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/ios/WebVideoFullscreenManagerProxy.mm (modified) (2 diffs)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2014-11-21  Eric Carlson  <eric.carlson@apple.com>
+
+        WebVideoFullscreenManagerProxy must clear pointers when invalidated
+        https://bugs.webkit.org/show_bug.cgi?id=138982
+
+        Reviewed by Jer Noble.
+
+        * UIProcess/ios/WebVideoFullscreenManagerProxy.mm:
+        (WebKit::WebVideoFullscreenManagerProxy::~WebVideoFullscreenManagerProxy): Call invalidate.
+        (WebKit::WebVideoFullscreenManagerProxy::invalidate): Set WebVideoFullscreenModel and
+            WebVideoFullscreenChangeObserver to NULL.
+
 2014-11-21  Timothy Horton  <timothy_horton@apple.com>
 

trunk/Source/WebKit2/UIProcess/ios/WebVideoFullscreenManagerProxy.mm

@@ -68 +68 @@
     if (!m_page)
         return;
-    m_page->process().removeMessageReceiver(Messages::WebVideoFullscreenManagerProxy::messageReceiverName(), m_page->pageID());
+    invalidate();
 }
 
@@ -74 +74 @@
 {
     WebVideoFullscreenInterfaceAVKit::invalidate();
+
+    setWebVideoFullscreenModel(nullptr);
+    setWebVideoFullscreenChangeObserver(nullptr);
 
     m_page->process().removeMessageReceiver(Messages::WebVideoFullscreenManagerProxy::messageReceiverName(), m_page->pageID());