⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 176551 in webkit


Ignore:
Timestamp:
Nov 27, 2014, 10:00:10 AM (12 years ago)
Author:
andersca@apple.com
Message:

Add a stubbed out WebVisitedLinkStore to WebViewGroup
​https://bugs.webkit.org/show_bug.cgi?id=139066

Reviewed by Antti Koivisto.

Source/WebKit:

  • WebKit.xcodeproj/project.pbxproj:

Source/WebKit/mac:

  • WebCoreSupport/WebViewGroup.h:

(WebViewGroup::visitedLinkStore):

  • WebCoreSupport/WebViewGroup.mm:

(WebViewGroup::WebViewGroup):

  • WebCoreSupport/WebVisitedLinkStore.h: Copied from Source/WebKit/mac/WebCoreSupport/WebViewGroup.h.
  • WebCoreSupport/WebVisitedLinkStore.mm: Copied from Source/WebKit/mac/WebCoreSupport/WebViewGroup.h.

(WebVisitedLinkStore::create):
(WebVisitedLinkStore::WebVisitedLinkStore):
(WebVisitedLinkStore::~WebVisitedLinkStore):
(WebVisitedLinkStore::isLinkVisited):
(WebVisitedLinkStore::addVisitedLink):

Location:
trunk/Source/WebKit
Files:
5 edited
2 copied

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebKit/ChangeLog

    r176469 r176551  
     12014-11-27  Anders Carlsson  <andersca@apple.com>
     2
     3        Add a stubbed out WebVisitedLinkStore to WebViewGroup
     4        https://bugs.webkit.org/show_bug.cgi?id=139066
     5
     6        Reviewed by Antti Koivisto.
     7
     8        * WebKit.xcodeproj/project.pbxproj:
     9
    1102014-11-21  Anders Carlsson  <andersca@apple.com>
    211

  • trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj

    r175182 r176551  
    5959                1AB1DAC118BC0232004B6A9F /* WebViewGroup.mm in Sources */ = {isa = PBXBuildFile; fileRef = 1AB1DABF18BC0232004B6A9F /* WebViewGroup.mm */; };
    6060                1AB1DAC218BC0232004B6A9F /* WebViewGroup.h in Headers */ = {isa = PBXBuildFile; fileRef = 1AB1DAC018BC0232004B6A9F /* WebViewGroup.h */; };
     61                1AC7176E1A26568A002E3115 /* WebVisitedLinkStore.mm in Sources */ = {isa = PBXBuildFile; fileRef = 1AC7176C1A26568A002E3115 /* WebVisitedLinkStore.mm */; };
     62                1AC7176F1A26568A002E3115 /* WebVisitedLinkStore.h in Headers */ = {isa = PBXBuildFile; fileRef = 1AC7176D1A26568A002E3115 /* WebVisitedLinkStore.h */; };
    6163                1AEA66D40DC6B1FF003D12BF /* WebNetscapePluginEventHandler.h in Headers */ = {isa = PBXBuildFile; fileRef = 1AEA66D20DC6B1FF003D12BF /* WebNetscapePluginEventHandler.h */; };
    6264                1AEA66D50DC6B1FF003D12BF /* WebNetscapePluginEventHandler.mm in Sources */ = {isa = PBXBuildFile; fileRef = 1AEA66D30DC6B1FF003D12BF /* WebNetscapePluginEventHandler.mm */; };
    … …  
    499501                1AB1DABF18BC0232004B6A9F /* WebViewGroup.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = WebViewGroup.mm; sourceTree = "<group>"; };
    500502                1AB1DAC018BC0232004B6A9F /* WebViewGroup.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WebViewGroup.h; sourceTree = "<group>"; };
     503                1AC7176C1A26568A002E3115 /* WebVisitedLinkStore.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = WebVisitedLinkStore.mm; sourceTree = "<group>"; };
     504                1AC7176D1A26568A002E3115 /* WebVisitedLinkStore.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WebVisitedLinkStore.h; sourceTree = "<group>"; };
    501505                1AEA66D20DC6B1FF003D12BF /* WebNetscapePluginEventHandler.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WebNetscapePluginEventHandler.h; sourceTree = "<group>"; };
    502506                1AEA66D30DC6B1FF003D12BF /* WebNetscapePluginEventHandler.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = WebNetscapePluginEventHandler.mm; sourceTree = "<group>"; };
    … …  
    15711575                                1AB1DAC018BC0232004B6A9F /* WebViewGroup.h */,
    15721576                                1AB1DABF18BC0232004B6A9F /* WebViewGroup.mm */,
     1577                                1AC7176D1A26568A002E3115 /* WebVisitedLinkStore.h */,
     1578                                1AC7176C1A26568A002E3115 /* WebVisitedLinkStore.mm */,
    15731579                        );
    15741580                        name = WebCoreSupport;
    … …  
    18651871                                939810B10824BF01008DF038 /* WebPluginContainerCheck.h in Headers */,
    18661872                                939810B00824BF01008DF038 /* WebPluginContainerPrivate.h in Headers */,
     1873                                1AC7176F1A26568A002E3115 /* WebVisitedLinkStore.h in Headers */,
    18671874                                939810370824BF01008DF038 /* WebPluginController.h in Headers */,
    18681875                                7C1FB3C21846E8E1001A03D8 /* WebAllowDenyPolicyListener.h in Headers */,
    … …  
    21492156                                14D825300AF955090004F057 /* WebChromeClient.mm in Sources */,
    21502157                                A10C1D711820300E0036883A /* WebInspectorClientIOS.mm in Sources */,
     2158                                1AC7176E1A26568A002E3115 /* WebVisitedLinkStore.mm in Sources */,
    21512159                                939810EB0824BF01008DF038 /* WebClipView.mm in Sources */,
    21522160                                065AD5A40B0C32C7005A2B1D /* WebContextMenuClient.mm in Sources */,

  • trunk/Source/WebKit/mac/ChangeLog

    r176544 r176551  
     12014-11-27  Anders Carlsson  <andersca@apple.com>
     2
     3        Add a stubbed out WebVisitedLinkStore to WebViewGroup
     4        https://bugs.webkit.org/show_bug.cgi?id=139066
     5
     6        Reviewed by Antti Koivisto.
     7
     8        * WebCoreSupport/WebViewGroup.h:
     9        (WebViewGroup::visitedLinkStore):
     10        * WebCoreSupport/WebViewGroup.mm:
     11        (WebViewGroup::WebViewGroup):
     12        * WebCoreSupport/WebVisitedLinkStore.h: Copied from Source/WebKit/mac/WebCoreSupport/WebViewGroup.h.
     13        * WebCoreSupport/WebVisitedLinkStore.mm: Copied from Source/WebKit/mac/WebCoreSupport/WebViewGroup.h.
     14        (WebVisitedLinkStore::create):
     15        (WebVisitedLinkStore::WebVisitedLinkStore):
     16        (WebVisitedLinkStore::~WebVisitedLinkStore):
     17        (WebVisitedLinkStore::isLinkVisited):
     18        (WebVisitedLinkStore::addVisitedLink):
     19
    1202014-11-25  Anders Carlsson  <andersca@apple.com>
    221

  • trunk/Source/WebKit/mac/WebCoreSupport/WebViewGroup.h

    r176542 r176551  
    2626#import <WebCore/UserContentController.h>
    2727
     28class WebVisitedLinkStore;
     29
    2830@class WebView;
    2931
    … …  
    3941
    4042    WebCore::UserContentController& userContentController() { return m_userContentController.get(); }
     43    WebVisitedLinkStore& visitedLinkStore() { return m_visitedLinkStore.get(); }
    4144
    4245private:
    … …  
    4750
    4851    Ref<WebCore::UserContentController> m_userContentController;
     52    Ref<WebVisitedLinkStore> m_visitedLinkStore;
    4953};

  • trunk/Source/WebKit/mac/WebCoreSupport/WebViewGroup.mm

    r176542 r176551  
    2727
    2828#import "WebView.h"
     29#import "WebVisitedLinkStore.h"
    2930#import <wtf/NeverDestroyed.h>
    3031#import <wtf/text/StringHash.h>
    … …  
    6263    : m_name(name)
    6364    , m_userContentController(*UserContentController::create())
     65    , m_visitedLinkStore(WebVisitedLinkStore::create())
    6466{
    6567}

  • trunk/Source/WebKit/mac/WebCoreSupport/WebVisitedLinkStore.h

    r176550 r176551  
    2424 */
    2525
    26 #import <WebCore/UserContentController.h>
     26#ifndef WebVisitedLinkStore_h
     27#define WebVisitedLinkStore_h
    2728
    28 @class WebView;
     29#import <WebCore/VisitedLinkStore.h>
     30#import <wtf/PassRef.h>
    2931
    30 class WebViewGroup : public RefCounted<WebViewGroup> {
     32class WebVisitedLinkStore final : public WebCore::VisitedLinkStore {
    3133public:
    32     static PassRefPtr<WebViewGroup> getOrCreate(const String& name);
    33     ~WebViewGroup();
    34 
    35     static WebViewGroup* get(const String& name);
    36 
    37     void addWebView(WebView *);
    38     void removeWebView(WebView *);
    39 
    40     WebCore::UserContentController& userContentController() { return m_userContentController.get(); }
     34    static PassRef<WebVisitedLinkStore> create();
     35    virtual ~WebVisitedLinkStore();
    4136
    4237private:
    43     WebViewGroup(const String& name);
     38    WebVisitedLinkStore();
    4439
    45     String m_name;
    46     HashSet<WebView *> m_webViews;
     40    virtual bool isLinkVisited(WebCore::Page&, WebCore::LinkHash, const WebCore::URL& baseURL, const AtomicString& attributeURL) override;
     41    virtual void addVisitedLink(WebCore::Page&, WebCore::LinkHash) override;
     42};
    4743
    48     Ref<WebCore::UserContentController> m_userContentController;
    49 };
     44#endif // WebVisitedLinkStore_h

  • trunk/Source/WebKit/mac/WebCoreSupport/WebVisitedLinkStore.mm

    r176550 r176551  
    2424 */
    2525
    26 #import <WebCore/UserContentController.h>
     26#import "WebVisitedLinkStore.h"
    2727
    28 @class WebView;
     28PassRef<WebVisitedLinkStore> WebVisitedLinkStore::create()
     29{
     30    return adoptRef(*new WebVisitedLinkStore);
     31}
    2932
    30 class WebViewGroup : public RefCounted<WebViewGroup> {
    31 public:
    32     static PassRefPtr<WebViewGroup> getOrCreate(const String& name);
    33     ~WebViewGroup();
     33WebVisitedLinkStore::WebVisitedLinkStore()
     34{
     35}
    3436
    35     static WebViewGroup* get(const String& name);
     37WebVisitedLinkStore::~WebVisitedLinkStore()
     38{
     39}
    3640
    37     void addWebView(WebView *);
    38     void removeWebView(WebView *);
     41bool WebVisitedLinkStore::isLinkVisited(WebCore::Page&, WebCore::LinkHash, const WebCore::URL& baseURL, const AtomicString& attributeURL)
     42{
     43    // FIXME: Implement.
     44    return false;
     45}
    3946
    40     WebCore::UserContentController& userContentController() { return m_userContentController.get(); }
    41 
    42 private:
    43     WebViewGroup(const String& name);
    44 
    45     String m_name;
    46     HashSet<WebView *> m_webViews;
    47 
    48     Ref<WebCore::UserContentController> m_userContentController;
    49 };
     47void WebVisitedLinkStore::addVisitedLink(WebCore::Page&, WebCore::LinkHash)
     48{
     49    // FIXME: Implement.
     50}
Note: See TracChangeset for help on using the changeset viewer.