Changeset 176554 in webkit

Timestamp:

Nov 27, 2014, 5:40:01 PM (12 years ago)

Author:

Antti Koivisto

Message:

CrashTracer: com.apple.WebKit.WebContent at com.apple.WebCore: WebCore::HTMLPlugInImageElement::updateSnapshot + 108
​https://bugs.webkit.org/show_bug.cgi?id=139057

Reviewed by Anders Carlsson.

No test, don't know how to repro.

• html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::updateSnapshot): Null check the renderer.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/HTMLPlugInImageElement.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-11-27  Antti Koivisto  <antti@apple.com>
+
+        CrashTracer: com.apple.WebKit.WebContent at com.apple.WebCore: WebCore::HTMLPlugInImageElement::updateSnapshot + 108
+        https://bugs.webkit.org/show_bug.cgi?id=139057
+
+        Reviewed by Anders Carlsson.
+
+        No test, don't know how to repro.
+
+        * html/HTMLPlugInImageElement.cpp:
+        (WebCore::HTMLPlugInImageElement::updateSnapshot): Null check the renderer.
+
 2014-11-27  Joanmarie Diggs  <jdiggs@igalia.com>
 

trunk/Source/WebCore/html/HTMLPlugInImageElement.cpp

@@ -333 +333 @@
     m_snapshotImage = image;
 
-    if (is<RenderSnapshottedPlugIn>(*renderer())) {
-        downcast<RenderSnapshottedPlugIn>(*renderer()).updateSnapshot(image);
-        return;
-    }
-
-    if (is<RenderEmbeddedObject>(*renderer()))
-        renderer()->repaint();
+    if (!renderer())
+        return;
+    auto& renderer = *this->renderer();
+
+    if (is<RenderSnapshottedPlugIn>(renderer)) {
+        downcast<RenderSnapshottedPlugIn>(renderer).updateSnapshot(image);
+        return;
+    }
+
+    if (is<RenderEmbeddedObject>(renderer))
+        renderer.repaint();
 }