Changeset 176560 in webkit

Timestamp:

Nov 28, 2014, 1:50:18 AM (12 years ago)

Author:

commit-queue@webkit.org

Message:

[EFL] Add warning if CMake version is too old for building with ninja.
​https://bugs.webkit.org/show_bug.cgi?id=139055

Patch by Bartlomiej Gajda <​b.gajda@samsung.com> on 2014-11-28
Reviewed by Gyuyoung Kim.

CMake need to be >= 2.8.10 to build WebKit using ninja, some repos don't have
that version in their repositories.

• efl/install-dependencies:

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• efl/install-dependencies (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2014-11-28  Bartlomiej Gajda  <b.gajda@samsung.com>
+
+        [EFL] Add warning if CMake version is too old for building with ninja.
+        https://bugs.webkit.org/show_bug.cgi?id=139055
+
+        Reviewed by Gyuyoung Kim.
+
+        CMake need to be >= 2.8.10 to build WebKit using ninja, some repos don't have
+        that version in their repositories.
+
+        * efl/install-dependencies:
+
 2014-11-28  Andrzej Badowski  <a.badowski@samsung.com>
 

trunk/Tools/efl/install-dependencies

@@ -15 +15 @@
 }
 
+function checkCmakeVersion() {
+    CMAKE_VERSION=`cmake --version`
+
+    VERSION=`echo "$CMAKE_VERSION" | awk '{split($3,num,".");
+    if (!(num[1]>2 || num[2]>8 || num[3]>=10))
+        printf $3}'`
+
+    if [ -n "${VERSION}" ]; then
+        echo "Warning: CMake version detected (${VERSION}) is lower then 2.8.10."
+        echo "  This will probably cause errors, as older version didn't support CMAKE_NINJA_FORCE_RESPONSE_FILE,"
+        echo "  which is needed now for building. (look at: https://lists.webkit.org/pipermail/webkit-gtk/2014-March/001809.html )"
+        echo ""
+
+        if [ -f "/etc/issue" ]; then
+            ubuntu_version=`cat /etc/issue`
+            if [[ $ubuntu_version == *Ubuntu\ 12.04* ]]; then
+                echo "  For Ubuntu 12.04 or 12.10 You might consider adding ppa from https://launchpad.net/~kalakris/+archive/ubuntu/cmake"
+            fi
+        fi
+    fi
+}
+
 function checkInstaller {
     # apt-get - Debian based distributions
@@ -20 +42 @@
     if [ $? -eq 0 ]; then
         installDependenciesWithApt
+        checkCmakeVersion;
         exit 0
     fi