Changeset 176569 in webkit

Timestamp:

Nov 28, 2014, 2:09:01 PM (12 years ago)

Author:

timothy_horton@apple.com

Message:

DataDetectors PageOverlay callbacks are never called
​https://bugs.webkit.org/show_bug.cgi?id=139067
<rdar://problem/19086676>

Reviewed by Anders Carlsson.

• Shared/mac/ActionMenuHitTestResult.mm:

(WebKit::ActionMenuHitTestResult::encode):
(WebKit::ActionMenuHitTestResult::decode):
Encode/decode the PageOverlay ID.

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• Shared/mac/ActionMenuHitTestResult.mm (modified) (2 diffs)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2014-11-26  Timothy Horton  <timothy_horton@apple.com>
+
+        DataDetectors PageOverlay callbacks are never called
+        https://bugs.webkit.org/show_bug.cgi?id=139067
+        <rdar://problem/19086676>
+
+        Reviewed by Anders Carlsson.
+
+        * Shared/mac/ActionMenuHitTestResult.mm:
+        (WebKit::ActionMenuHitTestResult::encode):
+        (WebKit::ActionMenuHitTestResult::decode):
+        Encode/decode the PageOverlay ID.
+
 2014-11-28  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebKit2/Shared/mac/ActionMenuHitTestResult.mm

@@ -62 +62 @@
 
         encoder << detectedDataBoundingBox;
+        encoder << detectedDataOriginatingPageOverlay;
 
         bool hasTextIndicator = detectedDataTextIndicator;
@@ -114 +115 @@
             return false;
 
+        if (!decoder.decode(actionMenuHitTestResult.detectedDataOriginatingPageOverlay))
+            return false;
+
         bool hasTextIndicator;
         if (!decoder.decode(hasTextIndicator))