⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 176697 in webkit


Ignore:
Timestamp:
Dec 2, 2014, 4:32:33 PM (12 years ago)
Author:
timothy_horton@apple.com
Message:

Remove a SnowLeopard-era quirk for QuickLook
​https://bugs.webkit.org/show_bug.cgi?id=139208
<rdar://problem/19121822>

Reviewed by Alexey Proskuryakov.

  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/EmptyClients.h:
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::subresourceCachePolicy):

  • loader/FrameLoaderClient.h:
  • platform/mac/QuickLookMac.h: Removed.
  • platform/mac/QuickLookMac.mm: Removed.
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm:
  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):

  • Shared/WebProcessCreationParameters.h:
  • UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::platformInitializeWebProcess):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::needsQuickLookResourceCachingQuirks): Deleted.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess):

  • WebProcess/WebProcess.h:

(WebKit::WebProcess::needsQuickLookResourceCachingQuirks): Deleted.

  • WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeWebProcess):

Location:
trunk/Source
Files:
2 deleted
18 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r176696 r176697  
     12014-12-02  Tim Horton  <timothy_horton@apple.com>
     2
     3        Remove a SnowLeopard-era quirk for QuickLook
     4        https://bugs.webkit.org/show_bug.cgi?id=139208
     5        <rdar://problem/19121822>
     6
     7        Reviewed by Alexey Proskuryakov.
     8
     9        * WebCore.exp.in:
     10        * WebCore.xcodeproj/project.pbxproj:
     11        * loader/EmptyClients.h:
     12        * loader/FrameLoader.cpp:
     13        (WebCore::FrameLoader::subresourceCachePolicy):
     14        * loader/FrameLoaderClient.h:
     15        * platform/mac/QuickLookMac.h: Removed.
     16        * platform/mac/QuickLookMac.mm: Removed.
     17
    1182014-12-02  Anders Carlsson  <andersca@apple.com>
    219

  • trunk/Source/WebCore/WebCore.exp.in

    r176675 r176697  
    243243__ZN7WebCore12PrintContextC1EPNS_5FrameE
    244244__ZN7WebCore12PrintContextD1Ev
    245 __ZN7WebCore12QuickLookMac42computeNeedsQuickLookResourceCachingQuirksEv
    246245__ZN7WebCore12RenderObject16paintingRootRectERNS_10LayoutRectE
    247246__ZN7WebCore12RenderObject19scrollRectToVisibleERKNS_10LayoutRectERKNS_15ScrollAlignmentES6_

  • trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj

    r176696 r176697  
    16161616                45FEA5CF156DDE8C00654101 /* Decimal.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 45FEA5CD156DDE8C00654101 /* Decimal.cpp */; };
    16171617                45FEA5D0156DDE8C00654101 /* Decimal.h in Headers */ = {isa = PBXBuildFile; fileRef = 45FEA5CE156DDE8C00654101 /* Decimal.h */; settings = {ATTRIBUTES = (Private, ); }; };
    1618                 4643783119F720EF001E38B3 /* QuickLookMac.h in Headers */ = {isa = PBXBuildFile; fileRef = 4643782F19F720EF001E38B3 /* QuickLookMac.h */; settings = {ATTRIBUTES = (Private, ); }; };
    1619                 4643783219F720EF001E38B3 /* QuickLookMac.mm in Sources */ = {isa = PBXBuildFile; fileRef = 4643783019F720EF001E38B3 /* QuickLookMac.mm */; };
    16201618                4689F1AF1267BAE100E8D380 /* FileMetadata.h in Headers */ = {isa = PBXBuildFile; fileRef = 4689F1AE1267BAE100E8D380 /* FileMetadata.h */; };
    16211619                490707E61219C04300D90E51 /* ANGLEWebKitBridge.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 490707E41219C04300D90E51 /* ANGLEWebKitBridge.cpp */; };
    … …  
    87128710                45FEA5CD156DDE8C00654101 /* Decimal.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = Decimal.cpp; sourceTree = "<group>"; };
    87138711                45FEA5CE156DDE8C00654101 /* Decimal.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = Decimal.h; sourceTree = "<group>"; };
    8714                 4643782F19F720EF001E38B3 /* QuickLookMac.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = QuickLookMac.h; sourceTree = "<group>"; };
    8715                 4643783019F720EF001E38B3 /* QuickLookMac.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = QuickLookMac.mm; sourceTree = "<group>"; };
    87168712                4689F1AE1267BAE100E8D380 /* FileMetadata.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = FileMetadata.h; path = platform/FileMetadata.h; sourceTree = "<group>"; };
    87178713                490707E41219C04300D90E51 /* ANGLEWebKitBridge.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = ANGLEWebKitBridge.cpp; sourceTree = "<group>"; };
    … …  
    1650916505                                29E4D8E016B0959800C84704 /* PlatformSpeechSynthesizerMac.mm */,
    1651016506                                0081FEFE16B0A2B6008AAA7A /* PublicSuffixMac.mm */,
    16511                                 4643782F19F720EF001E38B3 /* QuickLookMac.h */,
    16512                                 4643783019F720EF001E38B3 /* QuickLookMac.mm */,
    1651316507                                BCAE1FA512939DB7004CB026 /* ScrollAnimatorMac.h */,
    1651416508                                BC51156D12B1749C00C96754 /* ScrollAnimatorMac.mm */,
    … …  
    2572825722                                CE1252391A166FA000864480 /* QuickLookSPI.h in Headers */,
    2572925723                                A10DBF4718F92317000D70C6 /* QuickLookHandleClient.h in Headers */,
    25730                                 4643783119F720EF001E38B3 /* QuickLookMac.h in Headers */,
    2573125724                                072AE1E8183C0741000A5988 /* QuickTimePluginReplacement.h in Headers */,
    2573225725                                379E371713736A6600B9E919 /* QuotedPrintable.h in Headers */,
    … …  
    2921329206                                550A0BC9085F6039007353D6 /* QualifiedName.cpp in Sources */,
    2921429207                                442AF7AA102CDDEA008FD4D3 /* QuickLook.mm in Sources */,
    29215                                 4643783219F720EF001E38B3 /* QuickLookMac.mm in Sources */,
    2921629208                                072AE1E6183C0741000A5988 /* QuickTimePluginReplacement.mm in Sources */,
    2921729209                                379E371613736A6600B9E919 /* QuotedPrintable.cpp in Sources */,

  • trunk/Source/WebCore/loader/EmptyClients.h

    r176577 r176697  
    404404#endif
    405405
    406 #if PLATFORM(MAC)
    407     virtual bool needsQuickLookResourceCachingQuirks() const override { return false; }
    408 #endif
    409 
    410406    virtual bool isEmptyFrameLoaderClient() override { return true; }
    411407};

  • trunk/Source/WebCore/loader/FrameLoader.cpp

    r176683 r176697  
    21532153
    21542154    const ResourceRequest& request(documentLoader()->request());
    2155 #if PLATFORM(MAC)
    2156     if (request.cachePolicy() == ReloadIgnoringCacheData && !equalIgnoringCase(request.httpMethod(), "post") && m_client.needsQuickLookResourceCachingQuirks())
    2157         return CachePolicyRevalidate;
    2158 #endif
    2159 
    21602155    if (request.cachePolicy() == ReturnCacheDataElseLoad)
    21612156        return CachePolicyHistoryBuffer;

  • trunk/Source/WebCore/loader/FrameLoaderClient.h

    r176136 r176697  
    284284        virtual void registerForIconNotification(bool listen = true) = 0;
    285285
    286 #if PLATFORM(MAC)
    287         virtual bool needsQuickLookResourceCachingQuirks() const = 0;
    288 #endif
    289 
    290286#if PLATFORM(COCOA)
    291287        // Allow an accessibility object to retrieve a Frame parent if there's no PlatformWidget.

  • trunk/Source/WebKit/mac/ChangeLog

    r176695 r176697  
     12014-12-02  Tim Horton  <timothy_horton@apple.com>
     2
     3        Remove a SnowLeopard-era quirk for QuickLook
     4        https://bugs.webkit.org/show_bug.cgi?id=139208
     5        <rdar://problem/19121822>
     6
     7        Reviewed by Alexey Proskuryakov.
     8
     9        * WebCoreSupport/WebFrameLoaderClient.h:
     10        * WebCoreSupport/WebFrameLoaderClient.mm:
     11
    1122014-12-02  Tim Horton  <timothy_horton@apple.com>
    213

  • trunk/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.h

    r175055 r176697  
    240240#endif
    241241
    242 #if PLATFORM(MAC)
    243     virtual bool needsQuickLookResourceCachingQuirks() const override;
    244 #endif
    245 
    246242    virtual void contentFilterDidBlockLoad(std::unique_ptr<WebCore::ContentFilter>) override;
    247243

  • trunk/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm

    r176142 r176697  
    22502250#endif
    22512251
    2252 #if PLATFORM(MAC)
    2253 bool WebFrameLoaderClient::needsQuickLookResourceCachingQuirks() const
    2254 {
    2255     static const bool shouldUseQuickLookResourceCachingQuirks = QuickLookMac::computeNeedsQuickLookResourceCachingQuirks();
    2256     return shouldUseQuickLookResourceCachingQuirks;
    2257 }
    2258 #endif
    2259 
    22602252void WebFrameLoaderClient::contentFilterDidBlockLoad(std::unique_ptr<WebCore::ContentFilter> contentFilter)
    22612253{

  • trunk/Source/WebKit2/ChangeLog

    r176691 r176697  
     12014-12-02  Tim Horton  <timothy_horton@apple.com>
     2
     3        Remove a SnowLeopard-era quirk for QuickLook
     4        https://bugs.webkit.org/show_bug.cgi?id=139208
     5        <rdar://problem/19121822>
     6
     7        Reviewed by Alexey Proskuryakov.
     8
     9        * Shared/WebProcessCreationParameters.cpp:
     10        (WebKit::WebProcessCreationParameters::encode):
     11        (WebKit::WebProcessCreationParameters::decode):
     12        * Shared/WebProcessCreationParameters.h:
     13        * UIProcess/mac/WebContextMac.mm:
     14        (WebKit::WebContext::platformInitializeWebProcess):
     15        * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
     16        (WebKit::WebFrameLoaderClient::needsQuickLookResourceCachingQuirks): Deleted.
     17        * WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
     18        * WebProcess/WebProcess.cpp:
     19        (WebKit::WebProcess::WebProcess):
     20        * WebProcess/WebProcess.h:
     21        (WebKit::WebProcess::needsQuickLookResourceCachingQuirks): Deleted.
     22        * WebProcess/cocoa/WebProcessCocoa.mm:
     23        (WebKit::WebProcess::platformInitializeWebProcess):
     24
    1252014-12-02  Beth Dakin  <bdakin@apple.com>
    226

  • trunk/Source/WebKit2/Shared/WebProcessCreationParameters.cpp

    r175288 r176697  
    109109    encoder << presenterApplicationPid;
    110110    encoder << accessibilityEnhancedUserInterfaceEnabled;
    111     encoder << needsQuickLookResourceCachingQuirks;
    112111    encoder << nsURLCacheMemoryCapacity;
    113112    encoder << nsURLCacheDiskCapacity;
    … …  
    238237    if (!decoder.decode(parameters.accessibilityEnhancedUserInterfaceEnabled))
    239238        return false;
    240     if (!decoder.decode(parameters.needsQuickLookResourceCachingQuirks))
    241         return false;
    242239    if (!decoder.decode(parameters.nsURLCacheMemoryCapacity))
    243240        return false;

  • trunk/Source/WebKit2/Shared/WebProcessCreationParameters.h

    r175288 r176697  
    127127
    128128    bool accessibilityEnhancedUserInterfaceEnabled;
    129     bool needsQuickLookResourceCachingQuirks;
    130129
    131130    uint64_t nsURLCacheMemoryCapacity;

  • trunk/Source/WebKit2/UIProcess/mac/WebContextMac.mm

    r176347 r176697  
    168168#if PLATFORM(MAC)
    169169    parameters.accessibilityEnhancedUserInterfaceEnabled = [[NSApp accessibilityAttributeValue:@"AXEnhancedUserInterface"] boolValue];
    170     static const bool shouldUseQuickLookResourceCachingQuirks = QuickLookMac::computeNeedsQuickLookResourceCachingQuirks();
    171     parameters.needsQuickLookResourceCachingQuirks = shouldUseQuickLookResourceCachingQuirks;
    172170#else
    173171    parameters.accessibilityEnhancedUserInterfaceEnabled = false;
    174     parameters.needsQuickLookResourceCachingQuirks = false;
    175172#endif
    176173

  • trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp

    r176437 r176697  
    16431643#endif
    16441644
    1645 #if PLATFORM(MAC)
    1646 bool WebFrameLoaderClient::needsQuickLookResourceCachingQuirks() const
    1647 {
    1648     return WebProcess::shared().needsQuickLookResourceCachingQuirks();
    1649 }
    1650 #endif
    1651 
    16521645} // namespace WebKit

  • trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.h

    r176136 r176697  
    232232#endif
    233233
    234 #if PLATFORM(MAC)
    235     virtual bool needsQuickLookResourceCachingQuirks() const override;
    236 #endif
    237 
    238234#if ENABLE(CONTENT_FILTERING)
    239235    virtual void contentFilterDidBlockLoad(std::unique_ptr<WebCore::ContentFilter>) override;

  • trunk/Source/WebKit2/WebProcess/WebProcess.cpp

    r176459 r176697  
    162162    , m_clearResourceCachesDispatchGroup(0)
    163163#endif
    164 #if PLATFORM(MAC)
    165     , m_needsQuickLookResourceCachingQuirks(false)
    166 #endif
    167164    , m_fullKeyboardAccessEnabled(false)
    168165    , m_textCheckerState()

  • trunk/Source/WebKit2/WebProcess/WebProcess.h

    r176459 r176697  
    119119#endif
    120120
    121 #if PLATFORM(MAC)
    122     bool needsQuickLookResourceCachingQuirks() const { return m_needsQuickLookResourceCachingQuirks; }
    123 #endif
    124 
    125121    bool shouldPlugInAutoStartFromOrigin(WebPage&, const String& pageOrigin, const String& pluginOrigin, const String& mimeType);
    126122    void plugInDidStartFromOrigin(const String& pageOrigin, const String& pluginOrigin, const String& mimeType, WebCore::SessionID);
    … …  
    324320    bool m_shouldForceScreenFontSubstitution;
    325321#endif
    326 #if PLATFORM(MAC)
    327     bool m_needsQuickLookResourceCachingQuirks;
    328 #endif
    329322
    330323    bool m_fullKeyboardAccessEnabled;

  • trunk/Source/WebKit2/WebProcess/cocoa/WebProcessCocoa.mm

    r176450 r176697  
    196196
    197197    setEnhancedAccessibility(parameters.accessibilityEnhancedUserInterfaceEnabled);
    198 #if PLATFORM(MAC)
    199     m_needsQuickLookResourceCachingQuirks = parameters.needsQuickLookResourceCachingQuirks;
    200 #endif
    201198
    202199#if USE(APPKIT)
Note: See TracChangeset for help on using the changeset viewer.